Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert HTTPClientProvider to a struct #591

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Conversation

adam-fowler
Copy link
Member

Convert HTTPClientProvider to a struct so it can be extended without requiring a major version

@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Merging #591 (b35da25) into 7.x.x (c436780) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            7.x.x     #591      +/-   ##
==========================================
+ Coverage   80.42%   80.43%   +0.01%     
==========================================
  Files          77       77              
  Lines        6461     6467       +6     
==========================================
+ Hits         5196     5202       +6     
  Misses       1265     1265              
Files Coverage Δ
Sources/SotoCore/AWSClient.swift 92.08% <100.00%> (+0.15%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@adam-fowler adam-fowler merged commit 72ee45f into 7.x.x Oct 23, 2023
6 checks passed
@adam-fowler adam-fowler deleted the httpclient-provider-struct branch October 23, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants