Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enables auto-hiding! #227

Merged

Conversation

tthornton3-chwy
Copy link
Contributor

Hey hey hey! Hope all is well over there :D

I got sad by the lack of auto-hiding, and decided I wanted to frustrate/experiment myself getting it working again haha.

I am definitely NOT recommending we merge this in, but if Mozilla never adds in native support for this, this could work :P

I used this: https://github.com/xiaoxiaoflood/firefox-scripts?tab=readme-ov-file#instructions

Then sidebarAutoHide.uc.js:19 is where the meat and potatoes are. Essentially we stop this: https://searchfox.org/mozilla-central/source/browser/components/sidebar/SidebarState.sys.mjs#293 from happening, which ultimately is what is making us sad.

All-in-all this was a fun lil experiment, and anyone who is literally dying without this currently could potentially use this in the mean time lol.

@soulhotel
Copy link
Owner

Yep, using js crossed my mind too. Was hoping that this change wouldn't make it into Default and Dev Edition, but since its a result of the new sidebar splitter it's definitely here to stay, until they hopefully figure out auto-hiding themselves.

I'm turned off by the idea of forcing people to setup/maintain autoconfig, but for You and Others with the patience to set it up, I can just have the old style (collapsed icons) available through "nightly-override". And everyone else will just have to deal with the "completely hidden" auto-hiding, when their Browsers reach this 135 update.

Thank you for putting this all together. I think this is a good merge. Will look over it again in the morning.

@tthornton3-chwy
Copy link
Contributor Author

Oh I 100% agree haha, I hate the thought of needing people to set autoconfig up 🥲 this theme does so much without needing to do it, which is a testament on its own, so to have to do it now to get this to work hurts haha.
But yeah, I agree, the option may be nice for those who hate change/loves the auto-collapsing. Technically the config I brought in was the "extension+script" package, if we do wanna merge this sucker we could remove a few files to narrow it down to just scripts 🤔

@soulhotel
Copy link
Owner

Right, I was honestly thinking about leaving it, hoping I could somehow override mozilla's extension permissions for this FF Ultima Companion I made, it can read preferences for the theme, but lacks the permission to modify them. I asked chatgpt if it could be done in multiple ways with autoconfig, but don't think it's possible..

2024-12-17.22-59-19.mp4

But also, since this is a "theme with too many options", maybe You or someone else might find the extension module useful in the future, honestly, your call. I can always just link the source as a separate download link for anyone that wants the autoconfig files included.

@tthornton3-chwy
Copy link
Contributor Author

Oh interesting! I think that's a great idea! We definitely can do this with autoconfig, but the path of least resistance might be to re-create it using a script, similar to the userChrome Manager they got. Hmmmm 🤔

@soulhotel
Copy link
Owner

Do you mean building the extension inside of the script? I saw this repository by aminomancer. That could probably help me figure out how it's done. Either through a new settings page, or building a new sidebar.

My JS education is pretty minimal despite all of the extensions I've built. So this sort of project would take me a while to get done (because of priority and time).

Gonna merge this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wip Work in progress. No time table set.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants