Skip to content
This repository has been archived by the owner on Apr 29, 2022. It is now read-only.

[Question] Full dagger reflection support #22

Closed
molokoka opened this issue Dec 9, 2019 · 2 comments · Fixed by #25
Closed

[Question] Full dagger reflection support #22

molokoka opened this issue Dec 9, 2019 · 2 comments · Fixed by #25

Comments

@molokoka
Copy link

molokoka commented Dec 9, 2019 •
edited
Loading

Hello!

Your plugin is very useful, but do you plan to support full dagger reflection?
@runningcode
Copy link
Contributor

By full dagger reflection do you mean this?
I can add a flag to a configuration extension which would not add the dagger reflect annotation processor? Would that work?

runningcode pushed a commit that referenced this issue Dec 11, 2019
Add support for full reflection.
4048918 
This adds an option to the delect extension `addReflectAnnotationProcessor`.
This can be disabled in order to use the full reflection approach as outlined
[here](https://github.com/jakewharton/dagger-reflect#full-reflection).
When disabled, the dagger annotation processors are automatically
removed from the build.

Fixes #22
@runningcode runningcode mentioned this issue Dec 11, 2019
Merged
@runningcode
Copy link
Contributor

Check out #25 and let me know if that works for you!

runningcode pushed a commit that referenced this issue Dec 16, 2019
Add support for full reflection. (#25)
9108f30 
This adds an option to the delect extension `addReflectAnnotationProcessor`.
This can be disabled in order to use the full reflection approach as outlined
[here](https://github.com/jakewharton/dagger-reflect#full-reflection).
When disabled, the dagger annotation processors are automatically
removed from the build.

Fixes #22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for full reflection. soundcloud/delect
2 participants
@runningcode @molokoka