Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to check no line is forgotten when copying 5 lines with stride 2 #134

Merged
merged 1 commit into from
Aug 21, 2018
Merged

Add test to check no line is forgotten when copying 5 lines with stride 2 #134

merged 1 commit into from
Aug 21, 2018

Conversation

tdeo
Copy link
Contributor

@tdeo tdeo commented Feb 11, 2016

No description provided.

@tdeo
Copy link
Contributor Author

tdeo commented Feb 11, 2016

Anyway you could enable Travis build for PR? I can't manage to run the tests on my local machine, the script setup fails at

bin/lhm-spec-setup-cluster.sh: line 64: ./*/mysql_install_db: No such file or directory

And I don't have more instructions

@tdeo
Copy link
Contributor Author

tdeo commented Feb 18, 2016

@arthurnn this adds a test I can't manage to run

@tdeo
Copy link
Contributor Author

tdeo commented Mar 9, 2016

@arthurnn could you run that test someway ? To see if #127 is necessary

@tdeo
Copy link
Contributor Author

tdeo commented Feb 13, 2017

@arthurnn I finally was able to run this test on Travis on my fork and the test is failing

@nikoatwork
Copy link

@tdeo you can fix bin/lhm-spec-setup-cluster.sh: line 64: ./*/mysql_install_db: No such file or directory by exchanging it with which mysql_install_db inside the script. At least on unix that should to the trick

@tdeo tdeo mentioned this pull request Aug 25, 2017
@grobie grobie merged commit 74a1382 into soundcloud:master Aug 21, 2018
@tdeo tdeo deleted the test_forgotten_line branch August 22, 2018 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants