feat(stream-transform-from): create a new package #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…am-transform-from` package
…sformFromAsyncIterable` class
…d to a simple `createSource()` function
+ Re-create the `Transform` object every time testing. + Simplify tests that differ only in options with `describe.each()`.
…the `try ... catch` statement
…call the callback passed to `_flush()` method after finish
…terable` class + Rename the `done` property to `transformCallback + Rename the `callDoneFn` method to `callTransformCallback` + Remove the `pushError` method and add `finish` method in its place
+ Added a test that returns multiple chunks + Added a test for the type of chunks contained in the source
If there is a possibility that either the `objectMode` or the `readableObjectMode` option is not `true`, the return value should not be `unknown`.
… the next chunk is needed, not after transforming a chunk
Index signatures and `boolean` types are now supported.
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
…the stream I noticed that the timing of the flow changes when using the asynchronous API.
…ning Promise objects should only be created in tests. Creating it during test case generation could cause Promise errors to affect unrelated code.
…the stream We have not found a way to control when data is read from the Readable stream.
…TransformFromAsyncIterable#finish()` method Code Climate reported: + Function `finish` has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
…rmFromAsyncIterable` class
…`TransformFromAsyncIterable` class This reverts commit 28e9901.
…s after processing all chunks has been fixed in Node v15
…etting all the chunks This bug has been fixed in Node.js v15. + https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V15.md#15.0.0 + nodejs/node#34314 However, we have found a workaround that works for anything less than Node.js v15, so we will attempt to fix this bug in this package.
…tting all the chunks
…t code readable and organized
…eScript The size of the package is now smaller if `src` directory contents are included.
…disallowed in options
|
Code Climate has analyzed commit c307fad and detected 0 issues on this pull request. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.