Miscellaneous changes #314
Conversation
* Remove unused `react-hotkeys` * Use Blueprint components instead of CSS API * Remove commented/unnecessary code
Was previously causing dependency errors on Apple Silicon.
Done to make use of their prebuilt binaries for Node 20.
package.json
Outdated
| @@ -135,7 +132,6 @@ | |||
| ] | |||
| }, | |||
| "resolutions": { | |||
| "esbuild": "^0.18.20", | |||
| "**/gl": "^6.0.2" | |||
| "**/gl": "^8.0.2" | |||
There was a problem hiding this comment.
Hmm, @sayomaki this resolution seems to be breaking the CI again, which is weird, because locally, I can run the commands just fine.
This is different from frontend where I am faced with the same error locally.
This reverts commit 81db412.
|
Hope you don't mind if I add some minor changes alongside |
All's good! If you are free, could you help with the review? Thanks! |
…to misc-20240522
@leeyi45 bumping this |
…to misc-20240522
# Conflicts: # package.json # yarn.lock
| import { type Ace, require as acequire } from 'ace-builds'; | ||
| import { Card } from '@blueprintjs/core'; | ||
| import { require as acequire, type Ace } from 'ace-builds'; | ||
| import 'ace-builds/src-noconflict/ace'; | ||
| import 'ace-builds/src-noconflict/ext-language_tools'; |
There was a problem hiding this comment.
Does the js-slang theme work for you? It still doesn't for me
There was a problem hiding this comment.
Oops, I think your previous comment wasn't published yet that's why I couldn't see it. It's broken on Source Academy @ NUS as well. I suspect it's a js-slang issue, specifically the ace-builds version there is way too old. But I haven't looked at it yet
| @@ -2,3 +2,15 @@ | |||
| export function degreesToRadians(degrees: number): number { | |||
| return (degrees / 360) * (2 * Math.PI); | |||
| } | |||
|
|
|||
| export function hexToColor(hex: string): [number, number, number] { | |||
There was a problem hiding this comment.
I noticed that this function fails silently, should we change this?
Description
Cleaned up stuff.
Devserver now works on my computer.
yarn installnow works on my computer.Please refer to commit titles for changelog.
Type of change
Please delete options that are not relevant.