Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect command syntax appears to produce an "OK" response #9

Open
kierdavis opened this issue Jan 29, 2018 · 1 comment
Open

Incorrect command syntax appears to produce an "OK" response #9

kierdavis opened this issue Jan 29, 2018 · 1 comment

Comments

@kierdavis
Copy link
Member

robotd log:

: Sending to servo assembly: b'@6311 gpio-read -17\n'
: Got back from servo: b'# @6311 gpio-read -17\n'
: Got back from servo: b'@6311 + OK\r\n'
@kierdavis
Copy link
Member Author

The following are excerpts of the Arduino's serial output stream as commands are manually typed into its input stream. Since the Arduino echoes every command it receives as a comment line, it is not necessary to show the input stream as well.

False positive responses seem to occur when the command string is too long:

# @1 gpio-read foo
@1 - 
# @1 gpio-read foob
@1 - 
# @1 gpio-read fooba
@1 - 
# @1 gpio-read foobar
@1 + OK
# @1 gpio-read foobarr
@1 + OK

Sometimes it corrupts all following commands with valid command names:

# @1 gpio-read f
@1 - 
# @1 gpio-read f
@1 - 
# @1 gpio-read foobarr
@1 + OK
# @1 gpio-read f
@1 + OK
# @1 gpio-read f
@1 + OK

But not always:

# @1 gpio-read f
@1 - 
# @1 gpio-read f
@1 - 
# @1 gpio-read foobar
@1 + OK
# @1 gpio-read f
@1 - 
# @1 gpio-read 1
@1 - 
# @1 gpio-read
@1 + OK
# @1 gpio-read f
@1 - 

It's not limited to just arguments:

# @1 gpio-read foo
@1 - 
# @10 gpio-read foo
@10 - 
# @100 gpio-read foo
@100 - 
# @1000 gpio-read foo
@1000 - 
# @10000 gpio-read foo
@10000 + OK
# @1000 gpio-read foo
@1000 + OK
# @1 gpio-read foo
@1 + OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant