Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Audit Log Mixin Wrapper Around Audit Log Mixin #57

Closed
Tyagi-Sunny opened this issue Apr 21, 2023 · 1 comment · Fixed by #58
Closed

Add Audit Log Mixin Wrapper Around Audit Log Mixin #57

Tyagi-Sunny opened this issue Apr 21, 2023 · 1 comment · Fixed by #58
Assignees
@Tyagi-Sunny
Labels
released

Comments

@Tyagi-Sunny
Copy link
Contributor

Is your feature request related to a problem? Please describe.
add audit log mixin wrapper around mixin, that will let user to decide whether to generate audit logs or not

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.
@Tyagi-Sunny Tyagi-Sunny self-assigned this Apr 21, 2023
Tyagi-Sunny added a commit that referenced this issue Apr 21, 2023
@Tyagi-Sunny
feat(provider): add audit repos mixin wrapper
b53191f 
add audit repos mixin wrapper

BREAKING CHANGE:
Audit Repository Mixin return type changes and now to be returned as abstract class

GH-57
@Tyagi-Sunny Tyagi-Sunny mentioned this issue Apr 21, 2023
Merged
12 tasks
Tyagi-Sunny added a commit that referenced this issue Apr 25, 2023
@Tyagi-Sunny
feat(provider): added ConditionalAuditRepositoryMixin testcase, comme…
d52be6b 
…nted changes

added ConditionalAuditRepositoryMixin testcase, commented changes

BREAKING CHANGE:
audit repository mixin return type is abstract class

GH-57
Tyagi-Sunny added a commit that referenced this issue Apr 25, 2023
@Tyagi-Sunny
feat(provider): minor changes
1342615 
minor changes

BREAKING CHANGE:
AuditRepositoryMixin return class is abstract now

GH-57
Tyagi-Sunny added a commit that referenced this issue Apr 25, 2023
@Tyagi-Sunny
feat(mixin): add ConditionalAuditRepositoryMixin for configurable Aud…
311bae6 
…it Mixin

To be used when the actual audit mixin is to be configured from the flag in the environment variable
rather than the code

BREAKING CHANGE:
Audit Repository Mixin return type changed and now is being returned as an abstract class. This
doesn't affect 99% of the users because this mixin is already applied on the base class. Only those
who are directly assigned the mixin-ed class to some variable will have the type error showing them.

GH-57
shubhamp-sf pushed a commit that referenced this issue Apr 25, 2023
@Tyagi-Sunny
feat(mixin): add conditional audit repository mixin (#58)
10257b6 
To be used when the actual audit mixin is to be applied conditionally from the flag from the environment variables
rather than the code.

BREAKING CHANGE:
Audit Repository Mixin return type changed and now is being returned as an abstract class. This
doesn't affect 99% of the users because in crud repositories this mixin is already applied on the base class. Only those who are directly assigning the mixin-ed class to some variable will have the type error showing them.

GH-57
@sfdevops
Copy link
Contributor

🎉 This issue has been resolved in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyagi-Sunny Tyagi-Sunny

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(mixin): add conditional audit repository mixin sourcefuse/loopback4-audit-log
2 participants
@sfdevops @Tyagi-Sunny