feat(mixin): add conditional audit repository mixin #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyagi-Sunny
requested review from
samarpan-b,
akshatdubeysf,
yeshamavani and
shubhamp-sf
shubhamp-sf
requested changes
Apr 24, 2023
shubhamp-sf
requested changes
Apr 25, 2023
…it Mixin To be used when the actual audit mixin is to be configured from the flag in the environment variable rather than the code BREAKING CHANGE: Audit Repository Mixin return type changed and now is being returned as an abstract class. This doesn't affect 99% of the users because this mixin is already applied on the base class. Only those who are directly assigned the mixin-ed class to some variable will have the type error showing them. GH-57
shubhamp-sf
approved these changes
Apr 25, 2023
shubhamp-sf
changed the title
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ConditionalAuditRepositoryMixin. To be used when the actual audit mixin is to be configured from the flag in the environment variable rather than the code. So any repository passed into this conditional mixin will only have the Audit Mixin applied if that env flag is set to true.BREAKING CHANGE:
Audit Repository Mixin return type changed and now is being returned as an abstract class. This doesn't affect 99% of the users because this mixin is already applied on the base class. Only those who are directly assigned the mixin-ed class to some variable will have the type error showing them.
GH-57
Fixes #57
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: