Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mixin): forward options param to find and findById calls #65

Merged
merged 1 commit into from
May 12, 2023

Conversation

shubhamp-sf
Copy link
Contributor

Description

Fixes the implementation of updateAll, deleteAll, updateById and replaceById to forward the options params.

GH-64
Fixes #64

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

fixes the implementation of updateAll, deleteAll,
updateById and replaceById to forward the options params

GH-64
@shubhamp-sf shubhamp-sf merged commit f5d83cd into master May 12, 2023
@shubhamp-sf shubhamp-sf deleted the GH-64 branch May 12, 2023 09:53
@shubhamp-sf
Copy link
Contributor Author

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mixin: options aren't forwarded to the original repository class
2 participants