Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance German translation (2) #349

Merged
merged 2 commits into from
Aug 11, 2024
Merged

Conversation

NilsPvR
Copy link
Contributor

@NilsPvR NilsPvR commented Aug 9, 2024

As mentioned in the issue I went through the German translations and found some things which could be improved. I'll add a review to this PR to comment on my suggestions for the translations. I won't add any comments on the simple typos.

A code review by @warappa would be greatly appreciated.

Fixes #331

+ fix some typos and add missing translations
src/Resources/Locales/de_DE.axaml Show resolved Hide resolved
src/Resources/Locales/de_DE.axaml Show resolved Hide resolved
src/Resources/Locales/de_DE.axaml Show resolved Hide resolved
src/Resources/Locales/de_DE.axaml Show resolved Hide resolved
src/Resources/Locales/de_DE.axaml Show resolved Hide resolved
src/Resources/Locales/de_DE.axaml Show resolved Hide resolved
src/Resources/Locales/de_DE.axaml Show resolved Hide resolved
src/Resources/Locales/de_DE.axaml Show resolved Hide resolved
src/Resources/Locales/de_DE.axaml Show resolved Hide resolved
src/Resources/Locales/de_DE.axaml Show resolved Hide resolved
@warappa
Copy link
Contributor

warappa commented Aug 9, 2024

Hi @NilsPvR,
thank you for the improvements and thorough preparation (comments) of this PR!

I'm done reviewing. I left some comments but hopefully they are helpful for you!

@love-linger love-linger self-assigned this Aug 11, 2024
@love-linger love-linger added the enhancement New feature or request label Aug 11, 2024
@love-linger love-linger merged commit 492859f into sourcegit-scm:develop Aug 11, 2024
5 checks passed
@NilsPvR
Copy link
Contributor Author

NilsPvR commented Aug 11, 2024

Hey @warappa, thanks for the extensive review and all the added sources 💪. Was quite busy yesterday so I went through the comments now. I'll make a new PR once the last suggestions are resolved, since this PR is already merged.

@warappa
Copy link
Contributor

warappa commented Aug 11, 2024

Hi @NilsPvR, I think I'm through again. Thank you for the good collaboration! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants