Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Reimplement Grafana pgsql datasource env vars as Kubernetes secret #568

Merged
merged 5 commits into from
Oct 24, 2024

Conversation

marcleblanc2
Copy link
Contributor

Checklist

Test plan

Manual testing on test instance, with and without the config defined

@marcleblanc2 marcleblanc2 requested review from a team and jdpleiness and removed request for a team October 18, 2024 23:19
@jdpleiness
Copy link
Contributor

Copy link
Contributor

@jdpleiness jdpleiness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like CI is failing here. You need to run the /scripts/helm-docs.sh script to regenerate the docs. Once CI passes you should be good to go.

@marcleblanc2 marcleblanc2 merged commit 3b0546a into main Oct 24, 2024
5 checks passed
@marcleblanc2 marcleblanc2 deleted the marc/cody-airgapped-analytics branch October 24, 2024 14:09
@marcleblanc2 marcleblanc2 changed the title Add Kubernetes secret config for Grafana chore: Reimplement Grafana pgsql datasource env vars as Kubernetes secret Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants