Add SymbolInformation.kind
#156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first step towards closing #154. Previously, the only way to determine the type of a symbol was through `SymbolDescriptor.Suffix`. This solution was not ideal since `Suffix` had very coarse grained types, and it was intentionally named "suffix" to indicate it was primarily used to determine the syntax of the symbol (not semantics). This PR adds a new enum `SymbolInformation.Kind` to add first-class support to determine the type of a symbol.
|
cc/ @donsbot if you have a moment to review. |
varungandhi-src
approved these changes
May 23, 2023
|
I tried to include the union of kinds from Glean, LSP, and SemanticDB. One open question for me is whether we should order the kinds alphabetically or by the LSP order (and add custom Glean kinds at the end). My preference is to use alphabetical order like we did for |
|
I think it's safe to be wider than current specs (eg LSP). I had to add a few for our uses. Clients will refine the set if needed. Most indexers emit a small set is kinds, but do care about getting naming right |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step towards closing #154.
Previously, the only way to determine the type of a symbol was through
SymbolDescriptor.Suffix. This solution was not ideal sinceSuffixhad very coarse grained types, and it was intentionally named "suffix" to indicate it was primarily used to determine the syntax of the symbol (not semantics).This PR adds a new enum
SymbolInformation.Kindto add first-class support to determine the type of a symbol.Test plan
Green CI.