Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Regex is too limiting #4

Open
felixfbecker opened this issue May 26, 2019 · 0 comments
Open

Regex is too limiting #4

felixfbecker opened this issue May 26, 2019 · 0 comments

Comments

@felixfbecker
Copy link
Contributor

felixfbecker commented May 26, 2019

Currently lines matching this pattern are matched:

/start_?span\(['"]([^'"]+)['"]/gi

This is way too limiting. For example, in our own repo sourcegraph/sourcegraph, that only matches 2 (two) calls:

In sourcegraph-typescript, it only matches some helper functions with dynamic operation names:

Most calls are with StartSpanWithContext, or tracePromise/traceObservable in sourcegraph-typescript.

We need to find a solution for this to make the extension actually useful.

sqs added a commit that referenced this issue May 27, 2019
sqs added a commit that referenced this issue May 27, 2019
sqs added a commit that referenced this issue May 27, 2019
sqs added a commit that referenced this issue May 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant