This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
doc/observability: document new OpenTelemetry log format #34529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobheadxi
commented
Apr 26, 2022
Comment on lines
+43
to
+44
| "TraceId": "string (optional)", | ||
| "SpanId": "string (optional)", |
There was a problem hiding this comment.
Note that not only are these fields named differently to DataDog, the format of IDs is different as well: https://docs.datadoghq.com/tracing/connect_logs_and_traces/opentelemetry/
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff a643cdc...8547425.
|
54 tasks
daxmc99
approved these changes
Apr 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly in the context of this discussion, to demonstrate the considerable divergence between DataDog and OpenTelemetry's log fields. Part of https://github.com/sourcegraph/sourcegraph/issues/33192
cc Cloud DevOps, Delivery as an FYI!
Test plan
sg run docsite