Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

chore: Update @sentry/browser to latest version #39901

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

plibither8
Copy link
Contributor

@plibither8 plibither8 commented Aug 3, 2022

Closes #39899.

This PR updates the Sentry browser client to the latest major release (v7.8.1), with a minor change code change.

Test plan

Manually tested locally.

App preview:

Check out the client app preview documentation to learn more.

@cla-bot cla-bot bot added the cla-signed label Aug 3, 2022
@github-actions github-actions bot added the frontend-platform Issues related to our frontend platform, owned collectively by our frontend crew. label Aug 3, 2022
Comment on lines -25 to -26
} else if (event.stacktrace) {
keep = isExtensionStackTrace(event.stacktrace, extensionID)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following the deprecation of top-level stacktrace on events, this check is unnecessary, and stacktrace is not an object of event's interface.

@plibither8 plibither8 marked this pull request as ready for review August 3, 2022 20:14
@plibither8
Copy link
Contributor Author

Interesting, not sure why the scip-typescript check is failing 🤔, will have to check that.

Copy link
Member

@valerybugakov valerybugakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failed check is caused by the outage on the npm side. I restarted the check; let's see how it goes. Otherwise, lgtm!

@plibither8
Copy link
Contributor Author

Looks like it passed now! Merging :)

@plibither8 plibither8 merged commit 344ca2c into main Aug 4, 2022
@plibither8 plibither8 deleted the mihir/update-sentry-javascript branch August 4, 2022 11:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed frontend-platform Issues related to our frontend platform, owned collectively by our frontend crew.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update @sentry/browser dependency to v7.8.1
2 participants