Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

nix: bump to bazel 7.1 #61326

Merged
merged 1 commit into from
Mar 22, 2024
Merged

nix: bump to bazel 7.1 #61326

merged 1 commit into from
Mar 22, 2024

Conversation

Strum355
Copy link
Contributor

Using my fork with open PR: NixOS/nixpkgs#295615

Im needing 7.1 sooner than later, given its new features and this repo also using 7.1 (so all new features are fair game for it!)

Cached version is pushed to sourcegraph-noah.cachix.org, which I've added at the top here so you too can avoid building it locally 🙂

Test plan

Tested locally 😎

@Strum355 Strum355 added the nix For Nix(OS) related issues/PRs label Mar 21, 2024
@Strum355 Strum355 self-assigned this Mar 21, 2024
@cla-bot cla-bot bot added the cla-signed label Mar 21, 2024
Copy link
Contributor

@Chickensoupwithrice Chickensoupwithrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Able to build locally, and run sg start

@Strum355
Copy link
Contributor Author

Able to build locally, and run sg start

Fwiw we dont use nixpkgs' bazel on macos, so this only affects linux 😅

@Strum355 Strum355 merged commit 2f8990e into main Mar 22, 2024
10 checks passed
@Strum355 Strum355 deleted the nsc/nix-bazel-7.1 branch March 22, 2024 16:57
Comment on lines +4 to +7
nixConfig = {
extra-substituters = [ "https://sourcegraph-noah.cachix.org" ];
extra-trusted-public-keys = [ "sourcegraph-noah.cachix.org-1:rTTKnyuUmJuGt/UAXUpdOCOXDAfaO1AYy+/jSre3XgA=" ];
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my amd64 linux machine it still seemed to build bazel-7.1.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did it prompt you to trust this substituter? Can you figure out what the store path is and I can check if it matches what Id expect? nix path-info .#bazel_7 I think

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, I answered yes but just noticed this warning:

warning: ignoring untrusted substituter 'https://sourcegraph-noah.cachix.org', you are not a trusted user.
❯ nix path-info .#bazel_7
warning: ignoring untrusted substituter 'https://sourcegraph-noah.cachix.org', you are not a trusted user.
Run `man nix.conf` for more information on the `substituters` configuration option.
evaluating derivation 'git+file:///home/keegan/src/github.com/sourcegraph/sourcegraph#bazel_7'/nix/store/n63v6d0m4p32n7zl3aqvmdnzq3m0ajm4-bazel-7.1.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That path exists, so its a case of you needing to add your user to the list of trusted users in nix.conf, then itll work

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the warning without making my user effectively root :) keegancsmith/dotfiles@8936f44

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just finished reading about that as well, wew it is confusing!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annoyingly, the CLI prompts for adding the substituter as trusted if it isnt already, but only if youre a trusted user I presume, which makes the experience a bit better than you having to edit nix.conf :/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed nix For Nix(OS) related issues/PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants