This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
chore: skip failing tests #62820
Merged
chore: skip failing tests #62820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkling
approved these changes
May 21, 2024
fkling
added a commit
that referenced
this pull request
May 21, 2024
Follow up for #62820 to fix failing/skipped tests that are easy to fix (which is all but one).
3 tasks
fkling
added a commit
that referenced
this pull request
May 22, 2024
Follow up for #62820 to fix failing/skipped tests that are easy to fix (which is all but one).
fkling
added a commit
that referenced
this pull request
May 22, 2024
Follow up for #62820 to fix failing/skipped tests that are easy to fix (which is all but one).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dev infra team is making progress on the Playwright in CI topic in https://github.com/sourcegraph/sourcegraph/pull/62683 and https://github.com/sourcegraph/sourcegraph/pull/62560. I want to help them merge their work into main as soon as possible.
To make sure they can run the right tests in the CI process (and enable the right merge blockers), I want to skip tests that are currently failing with playwright, and funnel them into new tasks for making them work again.
I created a new ticket for fixing the failing tests: https://github.com/sourcegraph/sourcegraph/issues/62821
Test plan