Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding adoption by NASA #30

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adding adoption by NASA #30

wants to merge 2 commits into from

Conversation

Era-cell
Copy link
Contributor

@Era-cell Era-cell commented May 9, 2024

No description provided.

@Era-cell
Adding adoption by NASA
0a06a5d 
Signed-off-by: Suprith KG <suprith7kg@gmail.com>
jviotti
jviotti reviewed May 9, 2024
View reviewed changes
data.yaml Outdated Show resolved Hide resolved
jviotti
jviotti reviewed May 9, 2024
View reviewed changes
data.yaml Outdated Show resolved Hide resolved
jviotti
jviotti requested changes May 9, 2024
View reviewed changes
Copy link
Member

@jviotti jviotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments. Also, I think you forgot to run npm start as said on the contributing guide. Otherwise the README won't be re-generated

@Era-cell
Changes made according to the grammar
8f63b49 
Signed-off-by: Suprith KG <suprith7kg@gmail.com>

a
@Era-cell
Copy link
Contributor Author

Era-cell commented May 9, 2024

I left some comments. Also, I think you forgot to run npm start as said on the contributing guide. Otherwise the README won't be re-generated

Oh! I just pushed the yaml file. Guideline said - add directly to yaml and send a PR.. .

@jviotti
Copy link
Member

jviotti commented May 9, 2024

Feel free to clarify the contributing guide in another PR if you want!

@Era-cell
Copy link
Contributor Author

Era-cell commented May 9, 2024

Feel free to clarify the contributing guide in another PR if you want!

Screenshot 2024-05-09 232756
Like this is fine?

@jviotti
Copy link
Member

jviotti commented May 10, 2024

Something like that. If you send a PR, I can drop suggestions there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jviotti jviotti jviotti requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Era-cell @jviotti