Modify parent's CMAKE_MODULE_PATH
#1495
Merged
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jviotti
force-pushed
the
cmake-module-path
branch
from
765f7be to
b532498
Compare
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
jviotti
force-pushed
the
cmake-module-path
branch
from
b532498 to
4264afd
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark (linux/llvm)
| Benchmark suite | Current: 4264afd | Previous: 0e412c5 | Ratio |
|---|---|---|---|
Regex_Lower_S_Or_Upper_S_Asterisk |
2.2656308228965547 ns/iter |
2.2396275686213243 ns/iter |
1.01 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
2.226102611355883 ns/iter |
2.195174016366234 ns/iter |
1.01 |
Regex_Period_Asterisk |
2.2048393562889186 ns/iter |
2.2120228857797954 ns/iter |
1.00 |
Regex_Group_Period_Asterisk_Group |
2.1854135455915418 ns/iter |
2.2031442825686374 ns/iter |
0.99 |
Regex_Period_Plus |
2.4900998692752223 ns/iter |
2.7970872726682368 ns/iter |
0.89 |
Regex_Period |
2.487123944800777 ns/iter |
2.799476383058239 ns/iter |
0.89 |
Regex_Caret_Period_Plus_Dollar |
2.48933179893573 ns/iter |
2.797207684880886 ns/iter |
0.89 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
2.4881167906147783 ns/iter |
2.800803402044456 ns/iter |
0.89 |
Regex_Caret_Period_Asterisk_Dollar |
2.2145691534540095 ns/iter |
3.419356182568171 ns/iter |
0.65 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
2.2154229193036543 ns/iter |
3.4219484193662204 ns/iter |
0.65 |
Regex_Caret_X_Hyphen |
6.217321528008145 ns/iter |
13.088402993332869 ns/iter |
0.48 |
Regex_Period_Md_Dollar |
81.3395119526521 ns/iter |
83.71229420342829 ns/iter |
0.97 |
Regex_Caret_Slash_Period_Asterisk |
5.917730961017084 ns/iter |
6.837959357189969 ns/iter |
0.87 |
Regex_Caret_Period_Range_Dollar |
4.03969203807492 ns/iter |
4.081660381922056 ns/iter |
0.99 |
Regex_Nested_Backtrack |
503.00543899999184 ns/iter |
515.8088503151708 ns/iter |
0.98 |
JSON_Array_Of_Objects_Unique |
408.8374471337032 ns/iter |
409.1725984878157 ns/iter |
1.00 |
JSON_Parse_1 |
30190.99457340828 ns/iter |
30405.77834091288 ns/iter |
0.99 |
JSON_Fast_Hash_Helm_Chart_Lock |
58.45714756922372 ns/iter |
58.436744213570414 ns/iter |
1.00 |
JSON_Equality_Helm_Chart_Lock |
145.71381147909304 ns/iter |
151.1552603731091 ns/iter |
0.96 |
JSON_String_Equal/10 |
7.1437154799467235 ns/iter |
5.9194232577078445 ns/iter |
1.21 |
JSON_String_Equal/100 |
6.847711384875495 ns/iter |
6.539021797414839 ns/iter |
1.05 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
0.9350185364630784 ns/iter |
0.9346320647651425 ns/iter |
1.00 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
10.26076622228164 ns/iter |
10.253983726202502 ns/iter |
1.00 |
JSON_String_Fast_Hash/10 |
2.493889199096463 ns/iter |
2.486303258132849 ns/iter |
1.00 |
JSON_String_Fast_Hash/100 |
2.490491722139987 ns/iter |
2.4870079437519865 ns/iter |
1.00 |
JSON_String_Key_Hash/10 |
2.1787559417207736 ns/iter |
2.1769720302313376 ns/iter |
1.00 |
JSON_String_Key_Hash/100 |
1.8669100373436383 ns/iter |
1.8657475664742733 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Same_Length |
3.734534216328971 ns/iter |
3.7332159584549705 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Small |
3.7365772456598036 ns/iter |
3.7321235065399434 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Large |
3.735024858958495 ns/iter |
3.734854700592937 ns/iter |
1.00 |
Pointer_Object_Traverse |
44.26827756776908 ns/iter |
44.27543583732012 ns/iter |
1.00 |
Pointer_Object_Try_Traverse |
52.32579330597217 ns/iter |
52.438027412542034 ns/iter |
1.00 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
308.68513372736015 ns/iter |
289.2755251422284 ns/iter |
1.07 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (windows/msvc)
| Benchmark suite | Current: 4264afd | Previous: 0e412c5 | Ratio |
|---|---|---|---|
Regex_Lower_S_Or_Upper_S_Asterisk |
6.85132366071452 ns/iter |
7.508036830357057 ns/iter |
0.91 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
7.148218750000015 ns/iter |
6.873086607142349 ns/iter |
1.04 |
Regex_Period_Asterisk |
7.037376116071518 ns/iter |
7.063647321428691 ns/iter |
1.00 |
Regex_Group_Period_Asterisk_Group |
6.8808515624991475 ns/iter |
7.468047991070798 ns/iter |
0.92 |
Regex_Period_Plus |
7.235641741071116 ns/iter |
7.440190848214202 ns/iter |
0.97 |
Regex_Period |
7.334469866071558 ns/iter |
7.193405133928569 ns/iter |
1.02 |
Regex_Caret_Period_Plus_Dollar |
7.556426339285137 ns/iter |
7.241321428572382 ns/iter |
1.04 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
7.506636160714564 ns/iter |
7.213939285714487 ns/iter |
1.04 |
Regex_Caret_Period_Asterisk_Dollar |
6.834637500000034 ns/iter |
7.1370312500006 ns/iter |
0.96 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
7.298340401785199 ns/iter |
6.961060683208923 ns/iter |
1.05 |
Regex_Caret_X_Hyphen |
11.761232812499856 ns/iter |
14.303051052218931 ns/iter |
0.82 |
Regex_Period_Md_Dollar |
152.8402431767668 ns/iter |
167.34491071428437 ns/iter |
0.91 |
Regex_Caret_Slash_Period_Asterisk |
10.767649999999257 ns/iter |
10.495212499999898 ns/iter |
1.03 |
Regex_Caret_Period_Range_Dollar |
7.489280323707802 ns/iter |
8.13069866071484 ns/iter |
0.92 |
Regex_Nested_Backtrack |
651.7701785715044 ns/iter |
680.9861607142459 ns/iter |
0.96 |
JSON_Array_Of_Objects_Unique |
449.7771272918669 ns/iter |
449.72035721779093 ns/iter |
1.00 |
JSON_Parse_1 |
79485.02232142068 ns/iter |
80426.32812499713 ns/iter |
0.99 |
JSON_Fast_Hash_Helm_Chart_Lock |
67.04756249999174 ns/iter |
65.55948214285527 ns/iter |
1.02 |
JSON_Equality_Helm_Chart_Lock |
195.66301746991246 ns/iter |
196.95930593931584 ns/iter |
0.99 |
JSON_String_Equal/10 |
9.631341921288248 ns/iter |
9.625408885601725 ns/iter |
1.00 |
JSON_String_Equal/100 |
9.966291919794132 ns/iter |
10.010448437499875 ns/iter |
1.00 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
2.172283750000048 ns/iter |
2.169448749999958 ns/iter |
1.00 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
14.777636317957304 ns/iter |
14.458086096169014 ns/iter |
1.02 |
JSON_String_Fast_Hash/10 |
3.7169308862198807 ns/iter |
3.7197857142855026 ns/iter |
1.00 |
JSON_String_Fast_Hash/100 |
3.7157330290790203 ns/iter |
3.714014993367937 ns/iter |
1.00 |
JSON_String_Key_Hash/10 |
7.868042410714387 ns/iter |
7.4862421875008875 ns/iter |
1.05 |
JSON_String_Key_Hash/100 |
4.080097596571247 ns/iter |
4.0311259000552235 ns/iter |
1.01 |
JSON_Object_Defines_Miss_Same_Length |
3.720910730793358 ns/iter |
3.728165886199712 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Small |
3.7179128505038594 ns/iter |
3.7290257076267084 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Large |
4.955464000000802 ns/iter |
4.980037000000266 ns/iter |
1.00 |
Pointer_Object_Traverse |
52.62951785714978 ns/iter |
52.73817999999437 ns/iter |
1.00 |
Pointer_Object_Try_Traverse |
67.93483928571423 ns/iter |
68.08554464285521 ns/iter |
1.00 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
178.8637659699922 ns/iter |
165.7826070836718 ns/iter |
1.08 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (linux/gcc)
| Benchmark suite | Current: 4264afd | Previous: 0e412c5 | Ratio |
|---|---|---|---|
Pointer_Object_Traverse |
50.51376819370818 ns/iter |
49.45799026825746 ns/iter |
1.02 |
Pointer_Object_Try_Traverse |
26.486419064745217 ns/iter |
26.579027719213393 ns/iter |
1.00 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
144.97035794554188 ns/iter |
145.1234197432974 ns/iter |
1.00 |
JSON_Array_Of_Objects_Unique |
407.4457067682341 ns/iter |
408.7328402509402 ns/iter |
1.00 |
JSON_Parse_1 |
33872.50351106459 ns/iter |
33649.809793295506 ns/iter |
1.01 |
JSON_Fast_Hash_Helm_Chart_Lock |
62.548525461416574 ns/iter |
64.28127180432227 ns/iter |
0.97 |
JSON_Equality_Helm_Chart_Lock |
142.29945558760656 ns/iter |
140.2200473000727 ns/iter |
1.01 |
JSON_String_Equal/10 |
5.985020233574305 ns/iter |
5.992048923795726 ns/iter |
1.00 |
JSON_String_Equal/100 |
6.6133002440225575 ns/iter |
6.627780729082759 ns/iter |
1.00 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
0.6250409693190057 ns/iter |
0.6239605067769014 ns/iter |
1.00 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
14.29056555537185 ns/iter |
14.295853977025194 ns/iter |
1.00 |
JSON_String_Fast_Hash/10 |
0.9345379263117258 ns/iter |
0.933643406229567 ns/iter |
1.00 |
JSON_String_Fast_Hash/100 |
0.9319789219497415 ns/iter |
0.9335133391115921 ns/iter |
1.00 |
JSON_String_Key_Hash/10 |
1.7110725262368431 ns/iter |
1.7122485895870534 ns/iter |
1.00 |
JSON_String_Key_Hash/100 |
2.021971244662287 ns/iter |
2.021834685081522 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Same_Length |
3.1089519919355615 ns/iter |
3.1095445013430036 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Small |
2.7962786726694517 ns/iter |
2.7993262050702263 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Large |
2.485649722505565 ns/iter |
2.489468938662622 ns/iter |
1.00 |
Regex_Lower_S_Or_Upper_S_Asterisk |
2.7971161961985143 ns/iter |
2.797894130813322 ns/iter |
1.00 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
2.79689103854668 ns/iter |
2.7968019994325193 ns/iter |
1.00 |
Regex_Period_Asterisk |
2.7970539095826714 ns/iter |
2.800131945126322 ns/iter |
1.00 |
Regex_Group_Period_Asterisk_Group |
2.7968581002894277 ns/iter |
2.797900193216066 ns/iter |
1.00 |
Regex_Period_Plus |
3.450914829223905 ns/iter |
3.4206189129859546 ns/iter |
1.01 |
Regex_Period |
3.4180092202278334 ns/iter |
3.419303493543035 ns/iter |
1.00 |
Regex_Caret_Period_Plus_Dollar |
3.4156864030276606 ns/iter |
3.4192354183327502 ns/iter |
1.00 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
3.420695521283682 ns/iter |
3.4177868399103044 ns/iter |
1.00 |
Regex_Caret_Period_Asterisk_Dollar |
4.0458566543062595 ns/iter |
4.0441824131291595 ns/iter |
1.00 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
4.040765320022945 ns/iter |
4.043314280097133 ns/iter |
1.00 |
Regex_Caret_X_Hyphen |
13.051714369637333 ns/iter |
12.432213876928534 ns/iter |
1.05 |
Regex_Period_Md_Dollar |
92.98807353093405 ns/iter |
93.57934532080095 ns/iter |
0.99 |
Regex_Caret_Slash_Period_Asterisk |
7.459751771891438 ns/iter |
7.462955930969584 ns/iter |
1.00 |
Regex_Caret_Period_Range_Dollar |
4.351220284108287 ns/iter |
4.3538330769816715 ns/iter |
1.00 |
Regex_Nested_Backtrack |
825.1821560017521 ns/iter |
825.5662146462606 ns/iter |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (macos/llvm)
| Benchmark suite | Current: 4264afd | Previous: 0e412c5 | Ratio |
|---|---|---|---|
Regex_Lower_S_Or_Upper_S_Asterisk |
1.704630288566225 ns/iter |
1.7517433730234169 ns/iter |
0.97 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
1.81634885222789 ns/iter |
1.765145511085209 ns/iter |
1.03 |
Regex_Period_Asterisk |
1.7531659790853766 ns/iter |
1.7989363074814624 ns/iter |
0.97 |
Regex_Group_Period_Asterisk_Group |
1.7332305811652318 ns/iter |
1.8401807769979621 ns/iter |
0.94 |
Regex_Period_Plus |
2.4336921160126446 ns/iter |
2.089310271103068 ns/iter |
1.16 |
Regex_Period |
2.734438165675156 ns/iter |
2.122703667656963 ns/iter |
1.29 |
Regex_Caret_Period_Plus_Dollar |
2.2560631753846714 ns/iter |
2.0439182560652704 ns/iter |
1.10 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
2.6026052440020826 ns/iter |
2.0539450625522138 ns/iter |
1.27 |
Regex_Caret_Period_Asterisk_Dollar |
2.105047023949111 ns/iter |
1.6554444552007388 ns/iter |
1.27 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
2.136459299113163 ns/iter |
1.6892336502728096 ns/iter |
1.26 |
Regex_Caret_X_Hyphen |
9.00121330331418 ns/iter |
6.936702779266449 ns/iter |
1.30 |
Regex_Period_Md_Dollar |
88.41956375306654 ns/iter |
71.88055578363317 ns/iter |
1.23 |
Regex_Caret_Slash_Period_Asterisk |
5.994995127008135 ns/iter |
5.288463979351957 ns/iter |
1.13 |
Regex_Caret_Period_Range_Dollar |
2.520499965176121 ns/iter |
2.3005464974855334 ns/iter |
1.10 |
Regex_Nested_Backtrack |
920.7911903260167 ns/iter |
767.2740258049678 ns/iter |
1.20 |
JSON_Array_Of_Objects_Unique |
435.5195593727111 ns/iter |
352.10494662270355 ns/iter |
1.24 |
JSON_Parse_1 |
28323.57014302272 ns/iter |
22625.454736375206 ns/iter |
1.25 |
JSON_Fast_Hash_Helm_Chart_Lock |
67.9663809478726 ns/iter |
50.73335128101364 ns/iter |
1.34 |
JSON_Equality_Helm_Chart_Lock |
156.62033246393082 ns/iter |
126.88476022863513 ns/iter |
1.23 |
JSON_String_Equal/10 |
9.906197743570017 ns/iter |
7.982822978327019 ns/iter |
1.24 |
JSON_String_Equal/100 |
10.58388362210365 ns/iter |
6.137381990772591 ns/iter |
1.72 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
0.46290992669875375 ns/iter |
0.33017343302738816 ns/iter |
1.40 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
4.14125816094747 ns/iter |
3.0505615577345493 ns/iter |
1.36 |
JSON_String_Fast_Hash/10 |
1.9074609842279575 ns/iter |
1.69965943396688 ns/iter |
1.12 |
JSON_String_Fast_Hash/100 |
2.339679527680394 ns/iter |
2.1791994740539495 ns/iter |
1.07 |
JSON_String_Key_Hash/10 |
1.3661242742966064 ns/iter |
1.3666399520344097 ns/iter |
1.00 |
JSON_String_Key_Hash/100 |
1.8770639917779435 ns/iter |
1.335686191744944 ns/iter |
1.41 |
JSON_Object_Defines_Miss_Same_Length |
2.561378999997147 ns/iter |
2.3636404097154653 ns/iter |
1.08 |
JSON_Object_Defines_Miss_Too_Small |
2.55302933620776 ns/iter |
2.313926069184495 ns/iter |
1.10 |
JSON_Object_Defines_Miss_Too_Large |
2.5729251694839794 ns/iter |
2.3836123100032305 ns/iter |
1.08 |
Pointer_Object_Traverse |
21.151267944958583 ns/iter |
16.904358174160024 ns/iter |
1.25 |
Pointer_Object_Try_Traverse |
25.946024932055046 ns/iter |
23.818528448810053 ns/iter |
1.09 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
249.01290832887827 ns/iter |
183.66557947032456 ns/iter |
1.36 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (macos/gcc)
| Benchmark suite | Current: 4264afd | Previous: 0e412c5 | Ratio |
|---|---|---|---|
Regex_Lower_S_Or_Upper_S_Asterisk |
2.1815506304771546 ns/iter |
2.1409126551656668 ns/iter |
1.02 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
2.881957554441264 ns/iter |
2.1580175656179996 ns/iter |
1.34 |
Regex_Period_Asterisk |
2.1807078070924986 ns/iter |
2.104762202815379 ns/iter |
1.04 |
Regex_Group_Period_Asterisk_Group |
2.145449726598748 ns/iter |
2.0569224291648327 ns/iter |
1.04 |
Regex_Period_Plus |
1.8281888151198447 ns/iter |
1.7181063793774387 ns/iter |
1.06 |
Regex_Period |
2.160361356154458 ns/iter |
1.8051802437307378 ns/iter |
1.20 |
Regex_Caret_Period_Plus_Dollar |
2.6705956133097093 ns/iter |
1.8376753381747732 ns/iter |
1.45 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
2.430243961696846 ns/iter |
1.7735045840320398 ns/iter |
1.37 |
Regex_Caret_Period_Asterisk_Dollar |
3.089992094529911 ns/iter |
2.15870305863117 ns/iter |
1.43 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
2.312768905934508 ns/iter |
2.100492614730181 ns/iter |
1.10 |
Regex_Caret_X_Hyphen |
7.084898092921439 ns/iter |
6.557204234052495 ns/iter |
1.08 |
Regex_Period_Md_Dollar |
85.17241822274698 ns/iter |
81.45062473995087 ns/iter |
1.05 |
Regex_Caret_Slash_Period_Asterisk |
5.58398962020874 ns/iter |
5.016749284267371 ns/iter |
1.11 |
Regex_Caret_Period_Range_Dollar |
2.480033546464055 ns/iter |
2.287357386664964 ns/iter |
1.08 |
Regex_Nested_Backtrack |
1012.5003944648198 ns/iter |
893.7779114979661 ns/iter |
1.13 |
JSON_Array_Of_Objects_Unique |
298.0069304462518 ns/iter |
238.73825520319767 ns/iter |
1.25 |
JSON_Parse_1 |
33132.11351560405 ns/iter |
25575.218159098957 ns/iter |
1.30 |
JSON_Fast_Hash_Helm_Chart_Lock |
29.579512539543312 ns/iter |
25.73135990190156 ns/iter |
1.15 |
JSON_Equality_Helm_Chart_Lock |
148.26883671767985 ns/iter |
126.70109004710558 ns/iter |
1.17 |
JSON_String_Equal/10 |
6.816147466398794 ns/iter |
5.767880515770196 ns/iter |
1.18 |
JSON_String_Equal/100 |
6.34142868740374 ns/iter |
5.473027186976904 ns/iter |
1.16 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
1.2397887426364782 ns/iter |
0.9955108647469205 ns/iter |
1.25 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
4.5815713255225 ns/iter |
4.0110340922050325 ns/iter |
1.14 |
JSON_String_Fast_Hash/10 |
2.4431873637509813 ns/iter |
2.123962987339223 ns/iter |
1.15 |
JSON_String_Fast_Hash/100 |
2.359362716303257 ns/iter |
2.10473207602653 ns/iter |
1.12 |
JSON_String_Key_Hash/10 |
1.9289440018315578 ns/iter |
1.5779308179784413 ns/iter |
1.22 |
JSON_String_Key_Hash/100 |
2.209683040002114 ns/iter |
2.11141011244248 ns/iter |
1.05 |
JSON_Object_Defines_Miss_Same_Length |
2.320346322480019 ns/iter |
1.9586314261249635 ns/iter |
1.18 |
JSON_Object_Defines_Miss_Too_Small |
2.3428358317368962 ns/iter |
2.1198358822130743 ns/iter |
1.11 |
JSON_Object_Defines_Miss_Too_Large |
2.596168282093465 ns/iter |
2.0054130911444004 ns/iter |
1.29 |
Pointer_Object_Traverse |
78.794475227807 ns/iter |
59.45820148514879 ns/iter |
1.33 |
Pointer_Object_Try_Traverse |
45.147789802285686 ns/iter |
42.389750265114394 ns/iter |
1.07 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
205.85148539394487 ns/iter |
185.0678524504503 ns/iter |
1.11 |
This comment was automatically generated by workflow using github-action-benchmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com