-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve walker types to distinguish in-place applicators #1393
Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (linux/llvm)
Benchmark suite | Current: dd97b81 | Previous: 63a100d | Ratio |
---|---|---|---|
JSON_Array_Of_Objects_Unique |
443.239932319822 ns/iter |
444.2021439451723 ns/iter |
1.00 |
JSON_Parse_1 |
30428.88041443557 ns/iter |
31199.55256962739 ns/iter |
0.98 |
JSON_Fast_Hash_Helm_Chart_Lock |
54.667666786894266 ns/iter |
54.68049339889155 ns/iter |
1.00 |
JSON_Equality_Helm_Chart_Lock |
155.51030177768888 ns/iter |
146.7453759391702 ns/iter |
1.06 |
Regex_Lower_S_Or_Upper_S_Asterisk |
2.2101460808161 ns/iter |
2.48677504182712 ns/iter |
0.89 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
2.2021721424023193 ns/iter |
2.218322905199296 ns/iter |
0.99 |
Regex_Period_Asterisk |
2.2069329054632285 ns/iter |
2.495371545297191 ns/iter |
0.88 |
Regex_Group_Period_Asterisk_Group |
2.205296721162354 ns/iter |
2.2092418104678644 ns/iter |
1.00 |
Regex_Period_Plus |
2.45032489580866 ns/iter |
2.809864311591281 ns/iter |
0.87 |
Regex_Period |
2.25638448261639 ns/iter |
2.490717563052274 ns/iter |
0.91 |
Regex_Caret_Period_Plus_Dollar |
2.2643470541934727 ns/iter |
2.4901383074250116 ns/iter |
0.91 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
2.261302918702417 ns/iter |
2.5053960814118255 ns/iter |
0.90 |
Regex_Caret_Period_Asterisk_Dollar |
2.4848822988088513 ns/iter |
3.4180660285867446 ns/iter |
0.73 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
2.4856325263925108 ns/iter |
3.4221141935209993 ns/iter |
0.73 |
Regex_Caret_X_Hyphen |
13.055973848062063 ns/iter |
6.435722229625497 ns/iter |
2.03 |
Regex_Period_Md_Dollar |
73.55722413262063 ns/iter |
74.04506740729612 ns/iter |
0.99 |
Regex_Caret_Slash_Period_Asterisk |
7.167657850485325 ns/iter |
6.213554805762587 ns/iter |
1.15 |
Regex_Caret_Period_Range_Dollar |
3.727456487543842 ns/iter |
3.7295098771440105 ns/iter |
1.00 |
Regex_Nested_Backtrack |
493.094612181541 ns/iter |
504.7345797531528 ns/iter |
0.98 |
Pointer_Object_Traverse |
44.90231368078326 ns/iter |
44.93728358183502 ns/iter |
1.00 |
Pointer_Object_Try_Traverse |
52.30831895467381 ns/iter |
52.433158061167205 ns/iter |
1.00 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
352.13612516478645 ns/iter |
352.1666702787624 ns/iter |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (macos/llvm)
Benchmark suite | Current: dd97b81 | Previous: 63a100d | Ratio |
---|---|---|---|
JSON_Array_Of_Objects_Unique |
350.22075867596124 ns/iter |
328.3693185822481 ns/iter |
1.07 |
JSON_Parse_1 |
21677.69831272367 ns/iter |
21360.81400671402 ns/iter |
1.01 |
JSON_Fast_Hash_Helm_Chart_Lock |
52.92296471669972 ns/iter |
48.021827536297565 ns/iter |
1.10 |
JSON_Equality_Helm_Chart_Lock |
155.31778675080028 ns/iter |
140.41644215136668 ns/iter |
1.11 |
Regex_Lower_S_Or_Upper_S_Asterisk |
1.6613803965178708 ns/iter |
1.5758865985615966 ns/iter |
1.05 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
1.6047596659243248 ns/iter |
1.59409787531343 ns/iter |
1.01 |
Regex_Period_Asterisk |
1.6442683540262413 ns/iter |
1.5847696373610303 ns/iter |
1.04 |
Regex_Group_Period_Asterisk_Group |
1.7334736719724189 ns/iter |
1.5839997325832615 ns/iter |
1.09 |
Regex_Period_Plus |
1.9999780578442732 ns/iter |
1.8939383816820328 ns/iter |
1.06 |
Regex_Period |
1.994012035190214 ns/iter |
1.8835927453504728 ns/iter |
1.06 |
Regex_Caret_Period_Plus_Dollar |
2.0060685936640645 ns/iter |
1.879968459418958 ns/iter |
1.07 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
1.9742077579313755 ns/iter |
1.8975267159280482 ns/iter |
1.04 |
Regex_Caret_Period_Asterisk_Dollar |
1.6410925856929468 ns/iter |
1.5721938355960852 ns/iter |
1.04 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
1.7106130898162386 ns/iter |
1.5937183665256969 ns/iter |
1.07 |
Regex_Caret_X_Hyphen |
7.358810567418594 ns/iter |
6.392885145550519 ns/iter |
1.15 |
Regex_Period_Md_Dollar |
68.12792813440778 ns/iter |
71.48403964520539 ns/iter |
0.95 |
Regex_Caret_Slash_Period_Asterisk |
7.273003979997498 ns/iter |
4.909367844294187 ns/iter |
1.48 |
Regex_Caret_Period_Range_Dollar |
2.09288847779819 ns/iter |
2.101431268033422 ns/iter |
1.00 |
Regex_Nested_Backtrack |
762.5893832469663 ns/iter |
726.4735820359539 ns/iter |
1.05 |
Pointer_Object_Traverse |
15.212479491244299 ns/iter |
14.732014620287085 ns/iter |
1.03 |
Pointer_Object_Try_Traverse |
31.751552252815923 ns/iter |
31.39529282740664 ns/iter |
1.01 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
171.04463706566276 ns/iter |
173.3089781324295 ns/iter |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (windows/msvc)
Benchmark suite | Current: dd97b81 | Previous: 63a100d | Ratio |
---|---|---|---|
JSON_Array_Of_Objects_Unique |
416.95955845355934 ns/iter |
419.332907038581 ns/iter |
0.99 |
JSON_Parse_1 |
80688.51562500003 ns/iter |
80544.68750000915 ns/iter |
1.00 |
JSON_Fast_Hash_Helm_Chart_Lock |
53.532419999987724 ns/iter |
55.92464000000063 ns/iter |
0.96 |
JSON_Equality_Helm_Chart_Lock |
216.19115625000518 ns/iter |
217.77442331366316 ns/iter |
0.99 |
Regex_Lower_S_Or_Upper_S_Asterisk |
9.164603125000781 ns/iter |
8.306744419642902 ns/iter |
1.10 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
7.974166294642616 ns/iter |
7.905147286137287 ns/iter |
1.01 |
Regex_Period_Asterisk |
8.157294606440034 ns/iter |
7.783073660715242 ns/iter |
1.05 |
Regex_Group_Period_Asterisk_Group |
7.762893715343297 ns/iter |
7.851338169643388 ns/iter |
0.99 |
Regex_Period_Plus |
7.807127643717634 ns/iter |
8.224530133928353 ns/iter |
0.95 |
Regex_Period |
8.070186124688707 ns/iter |
8.023380580357246 ns/iter |
1.01 |
Regex_Caret_Period_Plus_Dollar |
7.839104429289435 ns/iter |
7.991587464322922 ns/iter |
0.98 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
8.204466927656766 ns/iter |
8.085526785714947 ns/iter |
1.01 |
Regex_Caret_Period_Asterisk_Dollar |
7.857909598212943 ns/iter |
7.845721839973764 ns/iter |
1.00 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
8.123887463732938 ns/iter |
7.774463804579055 ns/iter |
1.04 |
Regex_Caret_X_Hyphen |
11.61790714285514 ns/iter |
11.686676562499443 ns/iter |
0.99 |
Regex_Period_Md_Dollar |
141.47629725551081 ns/iter |
142.46772355056157 ns/iter |
0.99 |
Regex_Caret_Slash_Period_Asterisk |
11.933130357143845 ns/iter |
12.148396428571573 ns/iter |
0.98 |
Regex_Caret_Period_Range_Dollar |
9.02681379898814 ns/iter |
8.755829687499883 ns/iter |
1.03 |
Regex_Nested_Backtrack |
587.3547999999573 ns/iter |
589.4674107142554 ns/iter |
1.00 |
Pointer_Object_Traverse |
56.068705357148474 ns/iter |
56.210080357144776 ns/iter |
1.00 |
Pointer_Object_Try_Traverse |
76.03774553570324 ns/iter |
75.60409598214183 ns/iter |
1.01 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
182.3931238209365 ns/iter |
176.51183101640368 ns/iter |
1.03 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (linux/gcc)
Benchmark suite | Current: dd97b81 | Previous: 63a100d | Ratio |
---|---|---|---|
Pointer_Object_Traverse |
44.70804389559427 ns/iter |
44.3372179834315 ns/iter |
1.01 |
Pointer_Object_Try_Traverse |
22.421251787085662 ns/iter |
22.440061714765992 ns/iter |
1.00 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
213.4391944940288 ns/iter |
213.1757367503665 ns/iter |
1.00 |
Regex_Lower_S_Or_Upper_S_Asterisk |
2.48716320493659 ns/iter |
2.488436117109786 ns/iter |
1.00 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
2.488804555886855 ns/iter |
2.48788642266322 ns/iter |
1.00 |
Regex_Period_Asterisk |
2.487627104352209 ns/iter |
2.4873061807508563 ns/iter |
1.00 |
Regex_Group_Period_Asterisk_Group |
2.487321554238466 ns/iter |
2.4864234542982886 ns/iter |
1.00 |
Regex_Period_Plus |
2.772496492730725 ns/iter |
2.797500589750959 ns/iter |
0.99 |
Regex_Period |
2.485980469298648 ns/iter |
2.8156034135292667 ns/iter |
0.88 |
Regex_Caret_Period_Plus_Dollar |
2.551980443594379 ns/iter |
2.7997747355381497 ns/iter |
0.91 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
2.6176066955015718 ns/iter |
2.7974385097753824 ns/iter |
0.94 |
Regex_Caret_Period_Asterisk_Dollar |
2.8131960809497074 ns/iter |
3.728064895908564 ns/iter |
0.75 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
2.797053588369562 ns/iter |
3.7292106574083523 ns/iter |
0.75 |
Regex_Caret_X_Hyphen |
13.050055658892145 ns/iter |
12.43054874787288 ns/iter |
1.05 |
Regex_Period_Md_Dollar |
88.94923890959218 ns/iter |
87.81335215300726 ns/iter |
1.01 |
Regex_Caret_Slash_Period_Asterisk |
7.150311987891519 ns/iter |
7.155518909032307 ns/iter |
1.00 |
Regex_Caret_Period_Range_Dollar |
4.041878565353 ns/iter |
4.040291312430406 ns/iter |
1.00 |
Regex_Nested_Backtrack |
817.6612024621321 ns/iter |
813.5540930209013 ns/iter |
1.01 |
JSON_Array_Of_Objects_Unique |
379.5730823377495 ns/iter |
382.68132371336145 ns/iter |
0.99 |
JSON_Parse_1 |
32569.905485237043 ns/iter |
32737.87640977764 ns/iter |
0.99 |
JSON_Fast_Hash_Helm_Chart_Lock |
65.55955654732551 ns/iter |
66.8459186655842 ns/iter |
0.98 |
JSON_Equality_Helm_Chart_Lock |
142.19181192934593 ns/iter |
142.96795480959594 ns/iter |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com