refactor: Migrate mutation-relation tests to new framework #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
area/testing
orpheuslummis
approved these changes
Feb 16, 2023
| TransactionId: 0, | ||
|
|
||
| testUtils.TransactionRequest2{ | ||
| // Delete a liniked book that exists. |
There was a problem hiding this comment.
multiple instances of that typo: liniked
There was a problem hiding this comment.
See it. Say it. Sorted
There was a problem hiding this comment.
The code terrorists have won 😆 (also, I had no idea that phrase was/is used over here - thought it was a British thing lol)
There was a problem hiding this comment.
I've only ever heard that in London. I'm glad Canada reached (to some extent) independence.
shahzadlone
pushed a commit
that referenced
this pull request
Apr 13, 2023
* Add mutation/relation wrapper * Migrate TestTransactionalCreationAndLinkingOfRelationalDocumentsForward * Migrate TestTransactionalCreationAndLinkingOfRelationalDocumentsBackward * Migrate TestRelationalDeletionOfADocumentUsingSingleKey_Success * Migrate TestTxnDeletionOfRelatedDocFromPrimarySideForwardDirection * Migrate TestTxnDeletionOfRelatedDocFromPrimarySideBackwardDirection * Migrate TestATxnCanReadARecordThatIsDeletedInANonCommitedTxnForwardDirection * Migrate TestATxnCanReadARecordThatIsDeletedInANonCommitedTxnBackwardDirection * Migrate TestTxnDeletionOfRelatedDocFromNonPrimarySideForwardDirection * Migrate TestTxnDeletionOfRelatedDocFromNonPrimarySideBackwardDirection * Remove legacy framework wrapper
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
…work#1109) * Add mutation/relation wrapper * Migrate TestTransactionalCreationAndLinkingOfRelationalDocumentsForward * Migrate TestTransactionalCreationAndLinkingOfRelationalDocumentsBackward * Migrate TestRelationalDeletionOfADocumentUsingSingleKey_Success * Migrate TestTxnDeletionOfRelatedDocFromPrimarySideForwardDirection * Migrate TestTxnDeletionOfRelatedDocFromPrimarySideBackwardDirection * Migrate TestATxnCanReadARecordThatIsDeletedInANonCommitedTxnForwardDirection * Migrate TestATxnCanReadARecordThatIsDeletedInANonCommitedTxnBackwardDirection * Migrate TestTxnDeletionOfRelatedDocFromNonPrimarySideForwardDirection * Migrate TestTxnDeletionOfRelatedDocFromNonPrimarySideBackwardDirection * Remove legacy framework wrapper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Part of #1108
Description
Migrates mutation-relation integration tests to the new framework. Most of the work was done whilst waiting on another review. I'm parking this migration work for now and will otherwise be focusing on SchemaUpdates.