Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: review should be updated or create a new one. #427

Closed
3 tasks done
cnlangzi opened this issue Apr 19, 2024 · 5 comments
Closed
3 tasks done

feat: review should be updated or create a new one. #427

cnlangzi opened this issue Apr 19, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@cnlangzi
Copy link

Checklist

  • This is a new feature, not a refactoring suggestion
  • I have checked for this feature in the Sourcery documentation
  • I have checked there are no open requests referencing the same feature

Description

for now, sourcery ai create review as comment. It is impossible to click request re-review. and the review will be out of date if any new commit is pushed.
could we update it or create a new one with latest code again?

@cnlangzi cnlangzi added the enhancement New feature or request label Apr 19, 2024
@Hellebore
Copy link
Collaborator

@cnlangzi thanks for raising - this is on our roadmap and coming up shortly.

How would you prefer to request a re-review?
Options we're considering (also open to others):

  • comment something like @sourcery-ai review
  • adding a label
  • a checkbox in our summary comment

@cnlangzi
Copy link
Author

cnlangzi commented Apr 19, 2024

@cnlangzi thanks for raising - this is on our roadmap and coming up shortly.

How would you prefer to request a re-review? Options we're considering (also open to others):

  • comment something like @sourcery-ai review
  • adding a label
  • a checkbox in our summary comment

as human review, we will ask him to re-review when code is updated based on his comments.

@sourcery-ai review make senses. if so, maybe it is easier to do it automatically if code is updated.
eg dependabot, deepsource-io or codecov.

on dependabot, comment commands are optional. I just write it when I want to trigger it starts task immediately.

re review, to use built-in feature should be more friendly than new comment commands/label...etc.

@ruancomelli
Copy link
Contributor

Hello, @cnlangzi!

We recently released an update that allows you to request new reviews from Sourcery. Just comment

@sourcery-ai review

on a PR, and the Sourcery bot will start a new review.

Unfortunately, the built-in re-request feature can only be used to re-request reviews from human reviewers, not bots (like Sourcery).

Thanks for reaching out!

@cnlangzi
Copy link
Author

@ruancomelli it seems don't work properly. please check yaitoo/sqle#47 (review)

A new null.go file was added. but the robot says it is reviewed.

@ruancomelli
Copy link
Contributor

ruancomelli commented Jun 13, 2024

Hey @cnlangzi! This looks like a bug in the re-review mechanics. I opened a new GitHub issue to track this down: #428.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants