-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(string): added nullable String/Null for sql/json #47
Conversation
Reviewer's Guide by SourceryThis pull request introduces a nullable File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @cnlangzi - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Here's the code health analysis summary for commits Analysis Summary
|
@sourcery-ai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have skipped reviewing this pull request. It looks like we've already reviewed this pull request.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #47 +/- ##
==========================================
+ Coverage 76.76% 77.12% +0.35%
==========================================
Files 44 46 +2
Lines 1838 1884 +46
==========================================
+ Hits 1411 1453 +42
- Misses 304 306 +2
- Partials 123 125 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Changes
String
andNull
for sql/jsonSummary by Sourcery
This pull request introduces a new
String
type to handle nullable strings for SQL and JSON operations. It also refactors theTime
struct to use a common null handling mechanism and adds comprehensive tests for the newString
type.String
type to handle nullable strings for SQL and JSON operations.Time
struct to use a commonnullJsonBytes
andnullJson
for JSON null handling.String
type, including SQL insertions and JSON marshaling/unmarshaling.