Skip to content

Commit

Permalink
MRG: fix uploading of wheels after upload-artifact upgrade. (#2887)
Browse files Browse the repository at this point in the history
This fixes a problem introduced by
#2883, via the solution
mentioned
[here](https://github.com/actions/upload-artifact#not-uploading-to-the-same-artifact)
of naming artifacts using matrix variables.

The output artifacts from the updated `build_wheel.yml` are:
<img width="1062" alt="Screenshot 2023-12-19 at 1 41 24 PM"
src="https://github.com/sourmash-bio/sourmash/assets/51016/55bed1f6-e2e0-40ba-8d66-f6216078256e">

The output artifacts from the updated `build_wheel_all_archs.yml`:
<img width="1080" alt="Screenshot 2023-12-19 at 1 43 01 PM"
src="https://github.com/sourmash-bio/sourmash/assets/51016/3736f651-832b-468a-b2dd-ada6f866ad2b">
  • Loading branch information
ctb authored Dec 20, 2023
1 parent 172f664 commit 895dc15
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/build_wheel.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ jobs:

- uses: actions/upload-artifact@v4
with:
name: wheel-${{ matrix.build }}-${{ matrix.os }}
path: './wheelhouse/sourmash*.whl'

build_wasm:
Expand Down Expand Up @@ -81,6 +82,7 @@ jobs:
- uses: actions/upload-artifact@v4
with:
name: wheel-wasm
path: './dist/sourmash*.whl'


Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/build_wheel_all_archs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
- name: Upload wheels
uses: actions/upload-artifact@v4
with:
name: wheels
name: wheel-${{ matrix.target }}
path: dist

windows:
Expand All @@ -64,7 +64,7 @@ jobs:
- name: Upload wheels
uses: actions/upload-artifact@v4
with:
name: wheels
name: wheel-win64
path: dist

release:
Expand Down

0 comments on commit 895dc15

Please sign in to comment.