Build pyodide wheels in CI (#2433)

Following https://pyodide.org/en/latest/development/building-and-testing-packages.html#build-github-actions-example
sourmash-bio · Mar 6, 2023 · fecfc97 · fecfc97
1 parent 16979e8
commit fecfc97
Show file tree

Hide file tree

Showing 6 changed files with 172 additions and 15 deletions.
diff --git a/.github/workflows/build_wheel.yml b/.github/workflows/build_wheel.yml
@@ -55,11 +55,38 @@ jobs:
         with:
           path: './wheelhouse/sourmash*.whl'
 
+  build_wasm:
+    runs-on: ubuntu-20.04
+    steps:
+      - uses: actions/checkout@v3
+      - uses: actions/setup-python@v4
+        with:
+           python-version: 3.10.2
+      - run: |
+          pip install 'pyodide-build>=0.22.0'
+          pyodide config get emscripten_version  # trigger setup
+          echo EMSCRIPTEN_VERSION=$(pyodide config get emscripten_version) >> $GITHUB_ENV
+      - uses: mymindstorm/setup-emsdk@v11
+        with:
+           version: ${{ env.EMSCRIPTEN_VERSION }}
+      - uses: actions-rs/toolchain@v1
+        with:
+          toolchain: stable
+          target: wasm32-unknown-emscripten
+      - run: |
+          export RUSTC_BOOTSTRAP=1
+          pyodide build
+
+      - uses: actions/upload-artifact@v3
+        with:
+          path: './dist/sourmash*.whl'
+
+
   release:
     name: Publish wheels
     runs-on: ubuntu-20.04
     if: startsWith(github.ref, 'refs/tags/v')
-    needs: build_wheels
+    needs: [build_wheels, build_wasm]
 
     steps:
       - name: Fetch wheels from artifacts

diff --git a/.github/workflows/dev_envs.yml b/.github/workflows/dev_envs.yml
@@ -11,14 +11,19 @@ jobs:
       with:
         fetch-depth: 0
 
-    - uses: cachix/install-nix-action@v19
+    - uses: cachix/install-nix-action@v20
       with:
         extra_nix_config: |
           access-tokens = github.com=${{ secrets.GITHUB_TOKEN }}
 
+    - uses: cachix/cachix-action@v12
+      with:
+        name: sourmash-bio
+        authToken: '${{ secrets.CACHIX_AUTH_TOKEN }}'
+
     - run: nix run .# -- --version
 
-    - run: nix-shell --command "tox -e py39"
+    - run: nix-shell --command "tox -e py310"
 
   mamba:
     runs-on: ubuntu-latest

diff --git a/Cargo.lock b/Cargo.lock
diff --git a/src/core/Cargo.toml b/src/core/Cargo.toml
@@ -78,19 +78,23 @@ harness = false
 
 ## Wasm section. Crates only used for WASM, as well as specific configurations
 
-[target.'cfg(all(target_arch = "wasm32", target_vendor="unknown"))'.dependencies.wasm-bindgen]
+[target.'cfg(all(target_arch = "wasm32", target_os="unknown"))'.dependencies.wasm-bindgen]
 version = "0.2.84"
 features = ["serde-serialize"]
 
-[target.'cfg(all(target_arch = "wasm32", target_vendor="unknown"))'.dependencies.web-sys]
+[target.'cfg(all(target_arch = "wasm32", target_os="unknown"))'.dependencies.web-sys]
 version = "0.3.61"
 features = ["console", "File"]
 
-[target.'cfg(all(target_arch = "wasm32", target_vendor="unknown"))'.dev-dependencies]
+[target.'cfg(all(target_arch = "wasm32"))'.dependencies.chrono]
+version = "0.4.23"
+features = ["wasmbind"]
+
+[target.'cfg(all(target_arch = "wasm32", target_os="unknown"))'.dev-dependencies]
 wasm-bindgen-test = "0.3.34"
 
 ### These crates don't compile on wasm
-[target.'cfg(not(all(target_arch = "wasm32", target_vendor="unknown")))'.dependencies]
+[target.'cfg(not(all(target_arch = "wasm32", target_os="unknown")))'.dependencies]
 
 [package.metadata.maturin]
 name = "sourmash._lowlevel"
diff --git a/src/core/src/errors.rs b/src/core/src/errors.rs
@@ -63,7 +63,7 @@ pub enum SourmashError {
     #[error(transparent)]
     IOError(#[from] std::io::Error),
 
-    #[cfg(not(all(target_arch = "wasm32", target_vendor = "unknown")))]
+    #[cfg(not(all(target_arch = "wasm32", target_os = "unknown")))]
     #[error(transparent)]
     Panic(#[from] crate::ffi::utils::Panic),
 }
@@ -110,7 +110,7 @@ pub enum SourmashErrorCode {
     NifflerError = 100_005,
 }
 
-#[cfg(not(all(target_arch = "wasm32", target_vendor = "unknown")))]
+#[cfg(not(all(target_arch = "wasm32", target_os = "unknown")))]
 impl SourmashErrorCode {
     pub fn from_error(error: &SourmashError) -> SourmashErrorCode {
         match error {

diff --git a/src/core/src/lib.rs b/src/core/src/lib.rs
@@ -39,7 +39,8 @@ use cfg_if::cfg_if;
 use murmurhash3::murmurhash3_x64_128;
 
 cfg_if! {
-    if #[cfg(all(target_arch = "wasm32", target_vendor = "unknown"))] {
+    if #[cfg(all(target_arch = "wasm32", target_os = "unknown"))] {
+        // Explicitly keeping emscripten and wasi out of this
         pub mod wasm;
     } else {
         pub mod ffi;