-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create a MinHash
function to copy abundances from one MinHash
to another
#1463
Labels
good next issue
An issue that should be ready to resolve.
python
Pull requests that update Python code
Comments
ctb
added
python
Pull requests that update Python code
good next issue
An issue that should be ready to resolve.
labels
Apr 16, 2021
luizirber
added a commit
that referenced
this issue
May 10, 2021
add getset, wip parallel feature flag wip colors simpler impl first parallel hash to color construction wip Revert "wip" This reverts commit d65da76. must insert small_color into large_color before setting it trying out a small set impl try compressing colors inside reduce size test use new released vec-collections update cbindgen make parallel/sequential more maintainable some notes on partial serde start revindex in py start ffi first test passing second test passing modify colors.update to accept an iter instead of slices color count tracker update sourmash.h blanket implementation for counter_gather start working on memstorage niv update avoid a mut ref in save by using lots of mutexes fix codecov path fixes expose InnerStorage basic test passing in-memory sigs working revert counter_gather to gather in search.py lint cleanup cbindgen fixes moved MemStorage to #1463 implement signatures() fix initialization
@ctb Is this |
yes, in the |
(order doesn't matter) |
luizirber
added a commit
that referenced
this issue
Jun 21, 2021
add getset, wip parallel feature flag wip colors simpler impl first parallel hash to color construction wip Revert "wip" This reverts commit d65da76. must insert small_color into large_color before setting it trying out a small set impl try compressing colors inside reduce size test use new released vec-collections update cbindgen make parallel/sequential more maintainable some notes on partial serde start revindex in py start ffi first test passing second test passing modify colors.update to accept an iter instead of slices color count tracker update sourmash.h blanket implementation for counter_gather start working on memstorage niv update avoid a mut ref in save by using lots of mutexes fix codecov path fixes expose InnerStorage basic test passing in-memory sigs working revert counter_gather to gather in search.py lint cleanup cbindgen fixes moved MemStorage to #1463 implement signatures() fix initialization
luizirber
added a commit
that referenced
this issue
Dec 19, 2021
add getset, wip parallel feature flag wip colors simpler impl first parallel hash to color construction wip Revert "wip" This reverts commit d65da76. must insert small_color into large_color before setting it trying out a small set impl try compressing colors inside reduce size test use new released vec-collections update cbindgen make parallel/sequential more maintainable some notes on partial serde start revindex in py start ffi first test passing second test passing modify colors.update to accept an iter instead of slices color count tracker update sourmash.h blanket implementation for counter_gather start working on memstorage niv update avoid a mut ref in save by using lots of mutexes fix codecov path fixes expose InnerStorage basic test passing in-memory sigs working revert counter_gather to gather in search.py lint cleanup cbindgen fixes moved MemStorage to #1463 implement signatures() fix initialization
luizirber
added a commit
that referenced
this issue
Feb 12, 2022
add getset, wip parallel feature flag wip colors simpler impl first parallel hash to color construction wip Revert "wip" This reverts commit d65da76. must insert small_color into large_color before setting it trying out a small set impl try compressing colors inside reduce size test use new released vec-collections update cbindgen make parallel/sequential more maintainable some notes on partial serde start revindex in py start ffi first test passing second test passing modify colors.update to accept an iter instead of slices color count tracker update sourmash.h blanket implementation for counter_gather start working on memstorage niv update avoid a mut ref in save by using lots of mutexes fix codecov path fixes expose InnerStorage basic test passing in-memory sigs working revert counter_gather to gather in search.py lint cleanup cbindgen fixes moved MemStorage to #1463 implement signatures() fix initialization
luizirber
added a commit
that referenced
this issue
Feb 13, 2022
add getset, wip parallel feature flag wip colors simpler impl first parallel hash to color construction wip Revert "wip" This reverts commit d65da76. must insert small_color into large_color before setting it trying out a small set impl try compressing colors inside reduce size test use new released vec-collections update cbindgen make parallel/sequential more maintainable some notes on partial serde start revindex in py start ffi first test passing second test passing modify colors.update to accept an iter instead of slices color count tracker update sourmash.h blanket implementation for counter_gather start working on memstorage niv update avoid a mut ref in save by using lots of mutexes fix codecov path fixes expose InnerStorage basic test passing in-memory sigs working revert counter_gather to gather in search.py lint cleanup cbindgen fixes moved MemStorage to #1463 implement signatures() fix initialization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
good next issue
An issue that should be ready to resolve.
python
Pull requests that update Python code
Over in #1392, I implement a code block that retrieves abundances from a sketch using hashes; in
src/sourmash/commands.py
, functiongather
:Here,
next_query.minhash
is a flattenedMinHash
object derived fromorig_query_mh
, and we are constructing a newMinHash
objectabund_query_mh
that has all of the hashes fromnext_query.minhash
with abundances for those hashes taken fromorig_query_mh
.This is potentially a generically useful function that is kind of the converse of
flatten()
, so let's make it a method on theMinHash
class!TODO:
MinHash
objects (seesrc/sourmash/minhash.py
) named something likeinflate
;self
, aMinHash
object withtrack_abundance=True
;MinHash
object that borrows the abundances from the second argument using only the hashes fromself
;commands.gather()
with using this new function (and see if it can apply tomultigather
;tests/test_minhash.py
;The text was updated successfully, but these errors were encountered: