Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the -A flag to sourmash sig subtract to allow for signature subtraction from signatures with abundance tracking #1888

Closed
taylorreiter opened this issue Mar 17, 2022 · 3 comments · Fixed by #1889

Comments

@taylorreiter
Copy link
Contributor

I just tried to subtract a signature (a set of core genes) from another signature (a transcriptome), with the goal of getting track abund hashes from all expressed genes that were not in the core genome. I got the error, Cannot use subtract on signatures with abundance tracking, sorry! Would it be possible to add an -A flag like sourmash sig intersect has, so I could choose which signature to inherit abundances from??

@ctb
Copy link
Contributor

ctb commented Mar 17, 2022

yep - you want to subtract the hashes in a boolean fashion (present/not present), and then inherit the abundances on remaining hashes?

@taylorreiter
Copy link
Contributor Author

yes exactly!

@ctb
Copy link
Contributor

ctb commented Mar 18, 2022

working on it over here: #1889.

I have a bit more to do to round out the PR, but the current code should work. Also see the new sourmash sig inflate 😁

@ctb ctb closed this as completed in #1889 Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants