-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] add -A/--abundance-from
to sig subtract
& add sig inflate
#1889
Conversation
Codecov Report
@@ Coverage Diff @@
## latest #1889 +/- ##
==========================================
+ Coverage 82.64% 90.65% +8.01%
==========================================
Files 121 92 -29
Lines 13159 8998 -4161
Branches 1774 1780 +6
==========================================
- Hits 10875 8157 -2718
+ Misses 2018 577 -1441
+ Partials 266 264 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
-A/--abundance-from
to sourmash sig subtract
-A/--abundance-from
to sig subtract & add
sig inflate`
@taylorreiter thoughts and suggestions welcome! I think it's mostly done, will put it up for review if when I look at it with fresh eyes it seems good (and all the code is covered). |
ooooh |
-A/--abundance-from
to sig subtract & add
sig inflate`-A/--abundance-from
to sig subtract & add
sig inflate`
-A/--abundance-from
to sig subtract & add
sig inflate`-A/--abundance-from
to sig subtract
& add sig inflate
ok, this is now ready for review and merge @sourmash-bio/devs! No particular hurry. |
This PR adds
-A/--abundance-from
to thesourmash sig subtract
command, per #1888.It also:
MinHash.inflate(...)
in the situation whereself
is not a subset offrom_mh
MinHash.inflate(...)
sourmash sig intersect -A
to useMinHash.inflate(...)
sourmash sig inflate
Fixes #1888
Fixes #1706
TODO:
sourmash sig inflate
sourmash sig inflate
save_signatures
is being used (now in severalsourmash sig
commands do not use 'modern' signature output methods #1890)