several sourmash sig
commands do not use 'modern' signature output methods
#1890
Labels
good second issue
Second-tier issues for newer developers!
I noticed that several functions in
src/sourmash/sig/__main__.py
usesourmash.save_signatures(...)
insteads ofsourmash_args.SaveSignaturesToLocation(...)
. This means they only output JSON signatures, and will not save to .zip, directories, etc.To resolve this issue, replace all of the uses of
sourmash.save_signatures(...)
withsourmash_args.SaveSignaturesToLocation(...)
.You can use the code in
sourmash sig inflate
(#1889) as an example of how to do it. Note that you'll need to set the default value for-o/--output
to stdin ('-') to get the right stdout behavior.The text was updated successfully, but these errors were encountered: