Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

several sourmash sig commands do not use 'modern' signature output methods #1890

Open
ctb opened this issue Mar 18, 2022 · 0 comments
Open
Labels
good second issue Second-tier issues for newer developers!

Comments

@ctb
Copy link
Contributor

ctb commented Mar 18, 2022

I noticed that several functions in src/sourmash/sig/__main__.py use sourmash.save_signatures(...) insteads of sourmash_args.SaveSignaturesToLocation(...). This means they only output JSON signatures, and will not save to .zip, directories, etc.

To resolve this issue, replace all of the uses of sourmash.save_signatures(...) with sourmash_args.SaveSignaturesToLocation(...).

You can use the code in sourmash sig inflate (#1889) as an example of how to do it. Note that you'll need to set the default value for -o/--output to stdin ('-') to get the right stdout behavior.

@ctb ctb added the good second issue Second-tier issues for newer developers! label Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good second issue Second-tier issues for newer developers!
Projects
None yet
Development

No branches or pull requests

1 participant