Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sourmash compare error with --scaled flag #2398

Closed
jessicalumian opened this issue Dec 6, 2022 · 3 comments · Fixed by #2414
Closed

sourmash compare error with --scaled flag #2398

jessicalumian opened this issue Dec 6, 2022 · 3 comments · Fixed by #2414

Comments

@jessicalumian
Copy link

I'm running sourmash 4.5.0 in a conda env. When I ran

sourmash compare -k 31 --scaled 2000 input.sig -o test_cmp

I got the following error

sourmash: error: unrecognized arguments: --scaled

according to the help message, --scaled should be supported. If it's relevant, my input.sig was calculated with sourmash dna sketch for k = 21,31,51, a scaled value of 2000, and abundance tracking on.

@ctb
Copy link
Contributor

ctb commented Dec 7, 2022

according to the help message, --scaled should be supported.

actually turns out it's not listed there!

but I think maybe it should be supported 🤔

@jessicalumian
Copy link
Author

oooh oops you are right! I conflated gitter chat with the actual help message

@ctb
Copy link
Contributor

ctb commented Dec 20, 2022

Fixed over in #2414. Ready for review if you care to take a look ;)

@ctb ctb closed this as completed in #2414 Jan 13, 2023
ctb added a commit that referenced this issue Jan 13, 2023
Fixes #2398

Co-authored-by: Tessa Pierce Ward <bluegenes@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants