Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjust sourmash gather "overlap" documentation description #2835

Closed
jessicalumian opened this issue Nov 11, 2023 · 0 comments · Fixed by #2953
Closed

adjust sourmash gather "overlap" documentation description #2835

jessicalumian opened this issue Nov 11, 2023 · 0 comments · Fixed by #2953

Comments

@jessicalumian
Copy link

under gather docs: https://sourmash.readthedocs.io/en/latest/command-line.html#sourmash-gather-find-metagenome-members

“‘overlap’, the first column, is the estimated number of k-mers shared between the match and the query.”

I think instead this should this say something estimated number of base pairs based on kmers shared between match and query
ctb added a commit that referenced this issue Jan 29, 2024
@ctb
add fix for #2835
60177c5
@ctb ctb mentioned this issue Jan 29, 2024
Merged
@ctb ctb closed this as completed in #2953 Jan 30, 2024
ctb added a commit that referenced this issue Jan 30, 2024
@ctb
MRG: minor refactoring of gather code, small doc updates (#2953)
846e8ca 
This PR eliminates some unnecessary / duplicate code and renames some
variables to be more consistent.

Fixes #1831.
Fixes #1737.
Fixes #2835.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MRG: minor refactoring of gather code, small doc updates sourmash-bio/sourmash
1 participant
@jessicalumian