Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examine test running in nix flake #2907

Closed
ctb opened this issue Jan 13, 2024 · 0 comments · Fixed by #2992
Closed

examine test running in nix flake #2907

ctb opened this issue Jan 13, 2024 · 0 comments · Fixed by #2992

Comments

@ctb
Copy link
Contributor

ctb commented Jan 13, 2024

per review

Not all tests ran out of the box in the dev environment via the nix flake but were easily made to work and seem to work in the GitHub actions.
@ctb ctb mentioned this issue Jan 13, 2024
Closed
33 tasks
@luizirber luizirber mentioned this issue Feb 5, 2024
Merged
luizirber added a commit that referenced this issue Feb 10, 2024
@luizirber
nix updates for pyopensci review (#2975)
7edcf14 
Fix #2905 #2907 

- Use `DeterminateSystems/nix-installer-action` and
`DeterminateSystems/magic-nix-cache-action` for installing nix and
caching
- Also run nix on macos-14 (arm64)
- run `nix develop` instead of `nix-shell` to mirror direnv
@luizirber luizirber mentioned this issue Feb 11, 2024
Merged
luizirber added a commit that referenced this issue Feb 11, 2024
@luizirber @pre-commit-ci
Fix tox and nix configs so all tox tests execute correctly (#2992)
ec898ff 
Closes #2907

`tox -e docs` was failing due to missing env vars in tox.ini config
`tox -e khmer_master` fails to due to external errors now, it was
missing the URL for installing latest version from github.

Also limit test discovery in `hypothesis`, `khmer`, and `khmer_master`
to `doc tests`, avoiding going into `.tox` and other internal
directories containing python code.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix tox and nix configs so all tox tests execute correctly sourmash-bio/sourmash
1 participant
@ctb