-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] add initial progress reporting wrapper for load_file_as_signatures #1083
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1083 +/- ##
==========================================
+ Coverage 83.77% 92.90% +9.13%
==========================================
Files 99 74 -25
Lines 9005 5754 -3251
==========================================
- Hits 7544 5346 -2198
+ Misses 1461 408 -1053
Continue to review full report at Codecov.
|
Ready for review & merge! |
hmm, while it's still open -- I might
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This lgtm and seems to work :). I guess my main concern is not feeling familiar enough w/ all the code to be able to easily see if there's any spots you missed adding SignatureLoadingProgress
?
Partial fix for #1082
produces
This is all UX tweaking, no new tests.
make test
Did it pass the tests?make coverage
Is the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?