-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] define get_mins in terms of .hashes, not the other way around #1154
Conversation
Codecov Report
@@ Coverage Diff @@
## latest #1154 +/- ##
==========================================
+ Coverage 83.72% 92.95% +9.23%
==========================================
Files 95 71 -24
Lines 9006 5693 -3313
==========================================
- Hits 7540 5292 -2248
+ Misses 1466 401 -1065
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
5c8e1b6
to
2ebdf9a
Compare
Ready for review and merge @ctb Note that asv benchmarks are failing because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check removal of deprecated bits of code in 4.0? otherwise looks good!
This PR implements
.get_mins
and.get_hashes
in terms of.hashes
, as well as replacing their usage in tests by:.get_mins()
->.hashes.keys()
.get_mins(with_abundance=True)
->.hashes
.get_hashes()
->.hashes.keys()
(it also brings down the warnings count from 3975 to 1908...)
Checklist
make test
Did it pass the tests?make coverage
Is the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?