[MRG] Add a version.py => 2.0 alpha, add khmer@master to requirements.txt #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
==========================================
+ Coverage 85.34% 85.37% +0.03%
==========================================
Files 13 13
Lines 1829 1833 +4
Branches 52 52
==========================================
+ Hits 1561 1565 +4
Misses 259 259
Partials 9 9
Continue to review full report at Codecov.
|
|
Ready for review & maybe merge. |
luizirber
reviewed
Jan 20, 2017
setup.py
Outdated
| VERSION="1.1" | ||
| VERSION='undefined' | ||
| with open('sourmash_lib/version.py') as f: | ||
| exec(f.read()) |
There was a problem hiding this comment.
Hmmmm, can we use the other alternative from that answer, the one that doesn't need exec()?
There was a problem hiding this comment.
the "Store version string for use during install" one
ctb
changed the title
|
Ready for review! |
This was referenced Apr 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on sourmash_lib/VERSION to read the version from a single location.
make testDid it pass the tests?make coverageIs the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?