Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] fix Rust panic error in signature creation #1172

Merged
merged 2 commits into from
Aug 17, 2020

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Aug 16, 2020

Fixes #1166 by adjusting rust code to raise proper error on add_protein with a DNA hash function.

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@codecov
Copy link

codecov bot commented Aug 16, 2020

Codecov Report

Merging #1172 into latest will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           latest    #1172   +/-   ##
=======================================
  Coverage   84.05%   84.05%           
=======================================
  Files         100      100           
  Lines        9300     9300           
=======================================
  Hits         7817     7817           
  Misses       1483     1483           
Flag Coverage Δ
#rusttests 67.86% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/src/signature.rs 54.40% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d921fc3...a99db89. Read the comment docs.

@ctb ctb changed the title [WIP] fix Rust panic error in signature creation [MRG] fix Rust panic error in signature creation Aug 17, 2020
@ctb ctb requested a review from luizirber August 17, 2020 13:27
@luizirber luizirber merged commit eb35860 into latest Aug 17, 2020
@luizirber luizirber deleted the sigcreate_rust_panic branch August 17, 2020 20:46
@ctb ctb mentioned this pull request Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix Rust panic error in signature creation
2 participants