-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Remove --traverse-directory
from commands & make default
#1178
Conversation
--traverse-directory
is no longer explicitly required--traverse-directory
is no longer explicitly required
Codecov Report
@@ Coverage Diff @@
## latest #1178 +/- ##
==========================================
+ Coverage 84.10% 93.24% +9.13%
==========================================
Files 99 75 -24
Lines 9224 5906 -3318
==========================================
- Hits 7758 5507 -2251
+ Misses 1466 399 -1067
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
--traverse-directory
is no longer explicitly required--traverse-directory
from commands & make default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Old behavior in 2.x and 3.x: when the user wants to load all signatures from under a directory, they must specify
--traverse-directory
to the command.New behavior: if a directory is provided on the command line, it is automatically traversed for signatures (
*.sig
).-f
still forces loading filenames that do not end with.sig
.This PR also modifies
sourmash_args.load_dbs_sigs(...)
,.load_file_as_index(...)
, andload_file_as_signatures(...)
to no longer take atraverse
argument.Fixes #836
Fixes #1061
make test
Did it pass the tests?make coverage
Is the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?