Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Replace last .rst file from docs #1185

Merged
merged 1 commit into from
Sep 11, 2020
Merged

[MRG] Replace last .rst file from docs #1185

merged 1 commit into from
Sep 11, 2020

Conversation

luizirber
Copy link
Member

With #163 being fixed and myst-parser v0.12.2 released, we can replace the last .rst file from docs.

Checklist

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #1185 into latest will increase coverage by 9.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest    #1185      +/-   ##
==========================================
+ Coverage   84.13%   93.24%   +9.11%     
==========================================
  Files          99       75      -24     
  Lines        9219     5906    -3313     
==========================================
- Hits         7756     5507    -2249     
+ Misses       1463      399    -1064     
Flag Coverage Δ
#rusttests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/src/cmd.rs
src/core/src/index/search.rs
src/core/src/index/mod.rs
src/core/src/signature.rs
src/core/src/errors.rs
src/core/src/wasm.rs
src/core/src/from.rs
src/core/src/index/linear.rs
src/core/src/ffi/nodegraph.rs
src/core/src/sketch/nodegraph.rs
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e639bd...86f8541. Read the comment docs.

Copy link
Contributor

@ctb ctb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Merge when build finishes, pls.

@luizirber luizirber merged commit 7a8e5ac into latest Sep 11, 2020
@luizirber luizirber deleted the autodoc_myst branch September 11, 2020 00:24
@ctb ctb mentioned this pull request Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants