Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make cmdline sigs optional for lca index #1222

Merged
merged 2 commits into from
Oct 29, 2020
Merged

Conversation

bluegenes
Copy link
Contributor

@bluegenes bluegenes commented Oct 27, 2020

Makes sigs optional for lca index. Added a test with no cmdline signature, using --from-file. Arguments were already in correct order, thus tests did not need changing as in #1186.

Closes #1215.

  • Is it mergeable?
  • make test Did it pass the tests?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.

(no new code)

  • make coverage Is the new code covered?
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #1222 into latest will increase coverage by 9.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest    #1222      +/-   ##
==========================================
+ Coverage   84.22%   93.23%   +9.00%     
==========================================
  Files          99       75      -24     
  Lines        9232     5914    -3318     
==========================================
- Hits         7776     5514    -2262     
+ Misses       1456      400    -1056     
Flag Coverage Δ
#rusttests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sourmash/cli/lca/index.py 100.00% <ø> (ø)
src/core/tests/test.rs
src/core/src/sketch/minhash.rs
src/core/src/ffi/signature.rs
src/core/src/index/sbt/mhbt.rs
src/core/src/sketch/ukhs.rs
src/core/src/from.rs
src/core/tests/minhash.rs
src/core/src/index/search.rs
src/core/src/signature.rs
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df4c8cb...0ff1928. Read the comment docs.

@ctb
Copy link
Contributor

ctb commented Oct 28, 2020

looks ready for review, yah?

@bluegenes
Copy link
Contributor Author

yep!

@bluegenes bluegenes requested a review from ctb October 28, 2020 18:25
Copy link
Contributor

@ctb ctb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@ctb ctb merged commit 8587197 into latest Oct 29, 2020
@ctb ctb deleted the lcaindex-optional-cmdline-sigs branch October 29, 2020 14:36
@ctb ctb mentioned this pull request Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make cmdline sigs optional for lca index
2 participants