-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] add cibuildwheel to GitHub actions #1244
Conversation
Codecov Report
@@ Coverage Diff @@
## latest #1244 +/- ##
===========================================
- Coverage 83.31% 29.05% -54.27%
===========================================
Files 103 76 -27
Lines 9601 5910 -3691
===========================================
- Hits 7999 1717 -6282
- Misses 1602 4193 +2591
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
I'm taking over this PR and also bringing the remaining checks from Travis (no point in blocking PR merging because Travis is not running our builds) |
oh thank god
|
d79abd0
to
7844e72
Compare
8b7d409
to
726b66b
Compare
4db4a51
to
c509820
Compare
I disabled most tests from Travis, but didn't replace them yet with the GH actions version. I'll open a new PR for that, and leave this one only for fixing wheels (travis tests are not being executed anyway, since we are over our quota =/) |
And codecov is failing because the Python tests are not being reported 😬 Ready for review and merge @ctb |
c509820
to
61d0e07
Compare
I approve of it, but since I'm the original author I can't officially approve it for merge :). So... let's just merge when tests pass. |
Since TravisCI is no longer working well for building wheels, let's give GitHub Actions a try!
make test
Did it pass the tests?make coverage
Is the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?