Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Fix new clippy warnings from Rust 1.49 #1267

Merged
merged 1 commit into from
Jan 2, 2021
Merged

Conversation

luizirber
Copy link
Member

@luizirber luizirber commented Jan 2, 2021

CI started failing after Rust 1.49 was released, since 5 new clippy warnings showed up. This PR fixes them.

Checklist

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@codecov
Copy link

codecov bot commented Jan 2, 2021

Codecov Report

Merging #1267 (d22470e) into latest (ca201cf) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest    #1267      +/-   ##
==========================================
- Coverage   88.71%   88.67%   -0.04%     
==========================================
  Files         125      125              
  Lines       18238    18231       -7     
  Branches     1434     1434              
==========================================
- Hits        16180    16167      -13     
- Misses       1812     1818       +6     
  Partials      246      246              
Flag Coverage Δ
python 93.95% <ø> (ø)
rust 67.33% <100.00%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/src/index/sbt/mod.rs 67.07% <100.00%> (-0.31%) ⬇️
src/core/src/sketch/hyperloglog/mod.rs 81.76% <100.00%> (+0.55%) ⬆️
src/core/src/encodings.rs 77.77% <0.00%> (-1.59%) ⬇️
src/core/src/sketch/minhash.rs 91.31% <0.00%> (-1.06%) ⬇️
src/core/src/signature.rs 59.39% <0.00%> (-0.73%) ⬇️
src/core/src/ffi/minhash.rs 0.00% <0.00%> (ø)
src/core/src/ffi/nodegraph.rs 0.00% <0.00%> (ø)
src/core/src/ffi/cmd/compute.rs 0.00% <0.00%> (ø)
src/core/tests/minhash.rs 99.76% <0.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca201cf...d22470e. Read the comment docs.

@luizirber
Copy link
Member Author

Ready for review and merge @ctb

@luizirber luizirber merged commit 065f60b into latest Jan 2, 2021
@luizirber luizirber deleted the fix_rust_lint branch January 2, 2021 19:31
@ctb ctb mentioned this pull request Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants