Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Remove lca gather #1307

Merged
merged 2 commits into from
Feb 6, 2021
Merged

[MRG] Remove lca gather #1307

merged 2 commits into from
Feb 6, 2021

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Feb 6, 2021

Fixes #1183 by removing the lca gather command, associated tests, and associated documentation.

As a side note, I think this may be the last code-level change for 4.0...? 🎉

Checklist

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@ctb ctb requested a review from luizirber February 6, 2021 16:24
@codecov
Copy link

codecov bot commented Feb 6, 2021

Codecov Report

Merging #1307 (54b1bea) into latest (465a06d) will increase coverage by 5.32%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest    #1307      +/-   ##
==========================================
+ Coverage   88.72%   94.05%   +5.32%     
==========================================
  Files         125       96      -29     
  Lines       18374    14465    -3909     
  Branches     1438     1395      -43     
==========================================
- Hits        16303    13605    -2698     
+ Misses       1824      621    -1203     
+ Partials      247      239       -8     
Flag Coverage Δ
python 94.05% <100.00%> (+0.08%) ⬆️
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sourmash/cli/lca/__init__.py 100.00% <ø> (ø)
src/sourmash/lca/__init__.py 100.00% <ø> (ø)
tests/test_lca.py 99.86% <ø> (-0.01%) ⬇️
src/sourmash/lca/__main__.py 53.84% <100.00%> (ø)
src/sourmash/lca/lca_db.py 91.84% <0.00%> (-1.21%) ⬇️
src/core/src/sketch/minhash.rs
src/core/src/ffi/minhash.rs
src/core/src/ffi/mod.rs
src/core/src/from.rs
src/core/src/sketch/nodegraph.rs
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 465a06d...54b1bea. Read the comment docs.

@luizirber luizirber merged commit 55a2615 into latest Feb 6, 2021
@luizirber luizirber deleted the remove_lca_gather branch February 6, 2021 19:11
@ctb ctb mentioned this pull request Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove lca gather
2 participants