-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Refactor the gather_databases
function to use MinHash
API over Python set API.
#1512
Conversation
Co-authored-by: Tessa Pierce Ward <bluegenes@users.noreply.github.com>
Co-authored-by: Tessa Pierce Ward <bluegenes@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## latest #1512 +/- ##
==========================================
+ Coverage 90.25% 95.27% +5.02%
==========================================
Files 126 99 -27
Lines 21117 17404 -3713
Branches 1591 1589 -2
==========================================
- Hits 19059 16582 -2477
+ Misses 1829 593 -1236
Partials 229 229
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Ready for review and merge! (tests passed, just updated.) |
Much simplification and (potentially?) optimization of
gather_databases
function, based on various improvements in #1370 and #1475.