Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Refactor the gather_databases function to use MinHash API over Python set API. #1512

Merged
merged 267 commits into from
May 12, 2021

Conversation

ctb
Copy link
Contributor

@ctb ctb commented May 10, 2021

Much simplification and (potentially?) optimization of gather_databases function, based on various improvements in #1370 and #1475.

@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #1512 (a9ca357) into latest (91603d4) will increase coverage by 5.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest    #1512      +/-   ##
==========================================
+ Coverage   90.25%   95.27%   +5.02%     
==========================================
  Files         126       99      -27     
  Lines       21117    17404    -3713     
  Branches     1591     1589       -2     
==========================================
- Hits        19059    16582    -2477     
+ Misses       1829      593    -1236     
  Partials      229      229              
Flag Coverage Δ
python 95.27% <100.00%> (-0.01%) ⬇️
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sourmash/commands.py 86.27% <100.00%> (-0.02%) ⬇️
src/sourmash/search.py 96.24% <100.00%> (-0.21%) ⬇️
src/core/src/from.rs
src/core/src/index/search.rs
src/core/src/sketch/nodegraph.rs
src/core/src/sketch/hyperloglog/mod.rs
src/core/src/ffi/mod.rs
src/core/src/encodings.rs
src/core/src/ffi/cmd/compute.rs
src/core/src/index/mod.rs
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91603d4...a9ca357. Read the comment docs.

Base automatically changed from add/prefetch_cli to latest May 10, 2021 18:28
@ctb
Copy link
Contributor Author

ctb commented May 12, 2021

Ready for review and merge! (tests passed, just updated.)

@luizirber luizirber merged commit 6f1caf5 into latest May 12, 2021
@luizirber luizirber deleted the refactor/gather_db branch May 12, 2021 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants