[MRG] empty zipfile collections should not raise assertion errors when loaded #1546
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over in dib-lab/charcoal#171, @taylorreiter had to add checks for AssertionError in
load_file_as_signatures(...)
. It turns out this is because empty zipfile collections evaluate to empty, and there is a better-safe-than-sorry assertion in_load_database
that checks for empty databases.This PR changes that assertion to checking for unset database objections (
db is None
) and adds a test.Fixes #1545
@taylorreiter @bluegenes ready for review!