Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] add -d/--debug to sourmash sig describe; upgrade output errors. #1782

Merged
merged 4 commits into from
Mar 25, 2022

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Jan 4, 2022

This PR adds the -d/--debug flag to sourmash sig describe. This has become my go-to command for figuring out why signature collections (Index subclasses) aren't being loaded, and the debug output is really useful!

I also updated the output error messages upon failure to load files to be more explicit, in partial service of #1845.

@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #1782 (d9d3bff) into latest (515a06d) will increase coverage by 7.91%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           latest    #1782      +/-   ##
==========================================
+ Coverage   82.74%   90.65%   +7.91%     
==========================================
  Files         122       92      -30     
  Lines       13200     9001    -4199     
  Branches     1780     1780              
==========================================
- Hits        10922     8160    -2762     
+ Misses       2014      577    -1437     
  Partials      264      264              
Flag Coverage Δ
python 90.65% <100.00%> (+<0.01%) ⬆️
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sourmash/cli/sig/describe.py 100.00% <100.00%> (ø)
src/sourmash/sig/__main__.py 92.97% <100.00%> (+0.01%) ⬆️
src/core/src/from.rs
src/core/src/ffi/nodegraph.rs
src/core/src/sketch/hyperloglog/estimators.rs
src/core/src/ffi/signature.rs
src/core/src/index/linear.rs
src/core/src/ffi/index/revindex.rs
src/core/tests/storage.rs
src/core/src/ffi/utils.rs
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 515a06d...d9d3bff. Read the comment docs.

@ctb ctb changed the title [WIP] add -d/--debug to various commands [MRG] add -d/--debug to sourmash sig describe; upgrade output errors. Mar 25, 2022
@ctb
Copy link
Contributor Author

ctb commented Mar 25, 2022

Ready for review & merge @sourmash-bio/devs

Copy link
Contributor

@taylorreiter taylorreiter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@ctb ctb merged commit f54f60f into latest Mar 25, 2022
@ctb ctb deleted the add/debug branch March 25, 2022 15:24
@ctb
Copy link
Contributor Author

ctb commented Mar 25, 2022

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants