Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] add --output-dir as alias for every --outdir #1817

Merged
merged 5 commits into from
Feb 26, 2022
Merged

[MRG] add --output-dir as alias for every --outdir #1817

merged 5 commits into from
Feb 26, 2022

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Feb 2, 2022

This PR adds --output-dir as an alias for --outdir in commands that take --outdir to directing output to a directory.

Fixes #1812

  • consider adding --outdir to every --output-dir command too
  • maybe create an issue to swizzle the variable name to output_dir instead of outdir.

@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #1817 (0d9c88f) into latest (27826d8) will increase coverage by 8.06%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest    #1817      +/-   ##
==========================================
+ Coverage   82.25%   90.31%   +8.06%     
==========================================
  Files         119       89      -30     
  Lines       12918     8727    -4191     
  Branches     1727     1727              
==========================================
- Hits        10626     7882    -2744     
+ Misses       2026      579    -1447     
  Partials      266      266              
Flag Coverage Δ
python 90.31% <91.66%> (ø)
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sourmash/cli/compute.py 100.00% <ø> (ø)
src/sourmash/cli/sig/split.py 100.00% <ø> (ø)
src/sourmash/cli/sketch/dna.py 100.00% <ø> (ø)
src/sourmash/cli/sketch/protein.py 100.00% <ø> (ø)
src/sourmash/cli/sketch/translate.py 100.00% <ø> (ø)
src/sourmash/sig/__main__.py 91.75% <83.33%> (ø)
src/sourmash/command_compute.py 93.35% <100.00%> (ø)
src/sourmash/command_sketch.py 88.00% <100.00%> (ø)
src/core/src/ffi/index/mod.rs
src/core/src/index/sbt/mhbt.rs
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27826d8...0d9c88f. Read the comment docs.

@ctb ctb changed the title [WIP] add --output-dir as alias for every --outdir [MRG] add --output-dir as alias for every --outdir Feb 26, 2022
@ctb
Copy link
Contributor Author

ctb commented Feb 26, 2022

Ready for review @sourmash-bio/devs

Copy link
Contributor

@bluegenes bluegenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@ctb ctb merged commit c19b17c into latest Feb 26, 2022
@ctb ctb deleted the fix/outdir branch February 26, 2022 16:35
@ctb
Copy link
Contributor Author

ctb commented Feb 26, 2022

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variable output directory flags
2 participants