Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] alias sig fileinfo to sig summarize; minor docs, test cleanup #1863

Merged
merged 7 commits into from
Mar 5, 2022

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Mar 5, 2022

This PR implements several minor cleanup and feature additions:

  • aliases sourmash sig fileinfo to sourmash sig summarize per provide a summarization command for signature collections #1439
  • upgrades manifest and picklist documentation in the command-line docs
  • provides better manifest and fileinfo CLI usage help
  • does some pyflakes-based cleanup of tests, including rescuing three shadowed tests from copypasta mistakes

Fixes #1439

@codecov
Copy link

codecov bot commented Mar 5, 2022

Codecov Report

Merging #1863 (de073c0) into latest (4defa47) will increase coverage by 7.98%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest    #1863      +/-   ##
==========================================
+ Coverage   82.36%   90.34%   +7.98%     
==========================================
  Files         119       89      -30     
  Lines       12929     8732    -4197     
  Branches     1727     1727              
==========================================
- Hits        10649     7889    -2760     
+ Misses       2016      579    -1437     
  Partials      264      264              
Flag Coverage Δ
python 90.34% <100.00%> (+<0.01%) ⬆️
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sourmash/cli/sig/__init__.py 100.00% <100.00%> (ø)
src/sourmash/cli/sig/fileinfo.py 100.00% <100.00%> (ø)
src/sourmash/cli/sig/manifest.py 100.00% <100.00%> (ø)
src/sourmash/sig/__main__.py 91.78% <100.00%> (+0.02%) ⬆️
src/core/src/index/sbt/mod.rs
src/core/src/index/search.rs
src/core/src/sketch/hyperloglog/mod.rs
src/core/src/ffi/index/revindex.rs
src/core/src/cmd.rs
src/core/src/sketch/nodegraph.rs
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4defa47...de073c0. Read the comment docs.

@ctb
Copy link
Contributor Author

ctb commented Mar 5, 2022

Ready for review & merge @sourmash-bio/devs

@ctb ctb mentioned this pull request Mar 5, 2022
5 tasks
Copy link
Contributor

@bluegenes bluegenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ctb ctb merged commit e4617c8 into latest Mar 5, 2022
@ctb ctb deleted the cleanup/misc branch March 5, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

provide a summarization command for signature collections
2 participants