[MRG] add sum_hashes to sourmash sig describe output.
#1882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 12, 2022
Codecov Report
@@ Coverage Diff @@
## latest #1882 +/- ##
=======================================
Coverage 82.61% 82.62%
=======================================
Files 121 121
Lines 13105 13109 +4
Branches 1756 1756
=======================================
+ Hits 10827 10831 +4
Misses 2015 2015
Partials 263 263
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ctb
changed the title
sum_hashes to sourmash sig describe output.sum_hashes to sourmash sig describe output.
|
ready for review & merge @sourmash-bio/devs |
bluegenes
approved these changes
Mar 12, 2022
Yep! Added some doc text in 065b05b |
bluegenes
reviewed
Mar 12, 2022
doc/command-line.md
Outdated
| signature license: CC0 | ||
| ``` | ||
|
|
||
| Here, the `size` is the number of distinct hashes in the sketch, and | ||
| `sum_hashes` is the total number of hashes in the sketch, with abundances. | ||
| When `track_abundance` is 0, `size` is always the same as `sum_hashes. |
There was a problem hiding this comment.
is this missing a closing "`"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR -
sum hashes:to human readable output, andsum_hashesto CSV output, forsig dsecribe--include-db-patternand--exclude-db-patterntosig describesig describewheresignature_filewas always empty;Fixes #1833 by making
sum_hashesvisible (the last remaining part of that issue).