Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] implement sourmash sketch fromfile #1885

Merged
merged 155 commits into from
Apr 1, 2022
Merged

[MRG] implement sourmash sketch fromfile #1885

merged 155 commits into from
Apr 1, 2022

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Mar 13, 2022

Note: PR into #1907.

This PR creates a sourmash sketch fromfile command to support large-scale/batch construction of signatures.

Addresses #1671.
Fixes #1634.

TODO:

@codecov
Copy link

codecov bot commented Mar 13, 2022

Codecov Report

Merging #1885 (4f43d9e) into latest (d8102df) will increase coverage by 0.26%.
The diff coverage is 98.34%.

@@            Coverage Diff             @@
##           latest    #1885      +/-   ##
==========================================
+ Coverage   82.96%   83.22%   +0.26%     
==========================================
  Files         123      124       +1     
  Lines       13367    13601     +234     
  Branches     1808     1861      +53     
==========================================
+ Hits        11090    11320     +230     
- Misses       2013     2014       +1     
- Partials      264      267       +3     
Flag Coverage Δ
python 91.02% <98.34%> (+0.18%) ⬆️
rust 65.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sourmash/cli/sketch/dna.py 100.00% <ø> (ø)
src/sourmash/cli/sketch/protein.py 100.00% <ø> (ø)
src/sourmash/cli/sketch/translate.py 100.00% <ø> (ø)
src/sourmash/command_sketch.py 93.29% <97.96%> (+5.09%) ⬆️
src/sourmash/cli/sketch/__init__.py 100.00% <100.00%> (ø)
src/sourmash/cli/sketch/fromfile.py 100.00% <100.00%> (ø)
src/sourmash/command_compute.py 92.87% <100.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8102df...4f43d9e. Read the comment docs.

Base automatically changed from add/sketchfrom_support to latest March 14, 2022 17:01
@ctb ctb changed the base branch from latest to update/more_sketch_fromfile_support March 14, 2022 18:25
@ctb
Copy link
Contributor Author

ctb commented Apr 1, 2022

ok, I think the functionality here is largely done and at a good resting place. It's a bit of a monster PR and while I do have ideas on where to take the functionality next (AS DOES TESSA I'M SURE), I think it might be good to get this reviewed.

So, ready for review @sourmash-bio/devs !

@ctb ctb changed the title [WIP] implement sourmash sketch fromfile [MRG] implement sourmash sketch fromfile Apr 1, 2022
Copy link
Contributor

@bluegenes bluegenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉

doc/sourmash-sketch.md Outdated Show resolved Hide resolved
doc/sourmash-sketch.md Outdated Show resolved Hide resolved
src/sourmash/command_compute.py Show resolved Hide resolved
src/sourmash/command_sketch.py Show resolved Hide resolved
src/sourmash/command_sketch.py Show resolved Hide resolved
src/sourmash/command_sketch.py Outdated Show resolved Hide resolved
src/sourmash/command_sketch.py Show resolved Hide resolved
tests/test_sourmash_sketch.py Outdated Show resolved Hide resolved
tests/test_sourmash_sketch.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enable updating signature collections
2 participants